-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #23223 #23456
Automated cherry pick of #23223 #23456
Conversation
This PR is not for the master branch but does not have the |
Labelling this PR as size/M |
LGTM |
Tests failed. Also, the original PR hasn't even merged into master yet. |
this is a new one for me:
@k8s-bot unit test this please issue: #IGNORE |
This PR is not for the master branch but does not have the |
verify-godeps is failing in master. |
GCE e2e build/test passed for commit 3c14a6d. |
Is meaningless and should be ignored. (Those are the ONLY 4 lines I'm saying this about however) |
Why did the bot add "do-not-merge" label? There are no doc changes here. |
I believe the bot said why it did it: #23456 (comment)
|
So am I allowed to add cherrypick-approved, or do we wait until whoever is doing them as a batch does them all at once? We definitely want this in 1.2.1 |
This PR is not for the master branch but does not have the |
@bgrant0607 has been adding the label. We should ask him to review this / #23223 |
This PR is not for the master branch but does not have the |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3c14a6d. |
Automatic merge from submit-queue |
…pick-of-#23223-upstream-release-1.2 Auto commit by PR queue bot
…pick-of-#23223-upstream-release-1.2 Auto commit by PR queue bot
Cherry pick of #23223 on release-1.2.