add a delayed queueing option to the workqueue #23444
Conversation
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e build/test passed for commit a0f1c8d27a0e60246e786534bc97852d2408c0c1. |
|
@kubernetes/rh-cluster-infra |
| @@ -0,0 +1,135 @@ | |||
| /* | |||
| Copyright 2015 The Kubernetes Authors All rights reserved. | |||
deads2k
force-pushed
the
add-requeue-after-duration
branch
from
a0f1c8d to
487f97f
Compare
|
comments addressed. |
| } | ||
|
|
||
| go ret.waitingLoop() | ||
| ret.notifyAt(time.Now().Add(maxWait)) |
There was a problem hiding this comment.
time.Now() or clock.Now()
done
|
GCE e2e build/test failed for commit 487f97fe68b326355d28b47c788c8426fd2c960e. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
deads2k
force-pushed
the
add-requeue-after-duration
branch
from
487f97f to
b4a1d8f
Compare
|
GCE e2e build/test passed for commit b4a1d8f428fac9f1cc3eba5cf6f669def54cb9ca. |
| return ret | ||
| } | ||
|
|
||
| type delayingType struct { |
There was a problem hiding this comment.
I know this is internal, and maybe it should all be obvious, but it would be useful to have comments explaining each struct and its members.
There was a problem hiding this comment.
I know this is internal, and maybe it should all be obvious, but it would be useful to have comments explaining each struct and its members.
Will do.
There was a problem hiding this comment.
I know this is internal, and maybe it should all be obvious, but it would be useful to have comments explaining each struct and its members.
Lots of comments added.
| if duration < 0 || duration > maxWait { | ||
| duration = maxWait | ||
| } | ||
| nextReadyCheck = q.clock.Now().Add(duration) |
There was a problem hiding this comment.
Typo here. It needs to set the struct value.
deads2k
force-pushed
the
add-requeue-after-duration
branch
from
b4a1d8f to
e9d3354
Compare
|
Comments addressed. |
|
GCE e2e build/test passed for commit e9d3354b272e1f9076624a72286a704a4476b686. |
k8s-github-robot
added
the
size/XL
|
GCE e2e build/test passed for commit b403eef11b30288ad36e5c82a6ca4561e597a91f. |
deads2k
force-pushed
the
add-requeue-after-duration
branch
2 times, most recently
from
9f6ca38 to
a63a434
Compare
|
LGTM |
deads2k
force-pushed
the
add-requeue-after-duration
branch
from
a63a434 to
bf097ea
Compare
me too |
deads2k
added
the
lgtm
|
GCE e2e build/test passed for commit bf097ea. |
|
GCE e2e build/test passed for commit a63a434895de61da3c8db9a4a98d815a3bf671dc. |
|
Removing LGTM because the release note process has not been followed. |
k8s-github-robot
removed
the
lgtm
liggitt
added
lgtm
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e build/test passed for commit bf097ea. |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e build/test passed for commit bf097ea. |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e build/test passed for commit bf097ea. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit bf097ea. |
|
Automatic merge from submit-queue |
Adds delayed requeuing to the workqueue so that I requeue an item to be retried at some later time in my controller with a series of backoff rules. It lets me have the best of the retryManager and the work queue de-duping. Tracking failures and backoffs is on the caller
@smarterclayton @pweil- this would help us move to using the informer everywhere and de-duping at that level.