-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusty: Update heapster manifest handling code #23434
Conversation
Here is the e2e results. I tried a cluster with master and nodes on trusty, and also a cluster with only master on trusty. The results are the same: [Fail] [k8s.io] Addon update [BeforeEach] should propagate add-on file changes Ran 161 of 268 Specs in 4306.137 seconds This failure is a known issue #23221 and I am working on it. |
@Q-Lee , this fix is due to the change in #22893. Next time if you rename/add/remove a variable in the manifest, please change cluster/gce/trusty/configure-helper.sh also, or cc me and I will fix it. The comments of #22893 says the heapster change targets for 1.2.1, but I don't see it has a cherrypick-candidate label. May I know the latest status? If you decide to make it in 1.2.1, I have to cherry pick this fix also. Please notify me when you decide to cherry pick. Thanks. |
Labelling this PR as size/XS |
GCE e2e build/test passed for commit bfd68b3. |
LGTM |
@fgrzadkowski @piosz @mwielgus - FYI |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e build/test passed for commit bfd68b3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bfd68b3. |
GCE e2e build/test passed for commit bfd68b3. |
GCE e2e build/test passed for commit bfd68b3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bfd68b3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bfd68b3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bfd68b3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bfd68b3. |
Automatic merge from submit-queue |
The PR #22893 breaking us was just cherry picked in release-1.2 branch. Accordingly, we need to cherry pick this fix too. We need to do it ASAP, otherwise we may miss 1.2.2 release @k8s-oncall, please add "cherrypick-candidate" and "release-note" labels to this PR. I don't have permission to do it. |
Removing label |
…34-upstream-release-1.2 Automated cherry pick of #23434
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…ck-of-#23434-upstream-release-1.2 Automated cherry pick of kubernetes#23434
…ck-of-#23434-upstream-release-1.2 Automated cherry pick of kubernetes#23434
PR #22893 added new variables in the heapster manifest, but did not update the trusty support. This makes a breakage in starting heapster in trusty cluster.
@roberthbailey @dchen1107 @zmerlynn please review it.
cc/ @wonderfly @fabioy FYI