Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusty: Update heapster manifest handling code #23434

Merged
merged 1 commit into from
Mar 28, 2016
Merged

Trusty: Update heapster manifest handling code #23434

merged 1 commit into from
Mar 28, 2016

Conversation

andyzheng0831
Copy link

PR #22893 added new variables in the heapster manifest, but did not update the trusty support. This makes a breakage in starting heapster in trusty cluster.

@roberthbailey @dchen1107 @zmerlynn please review it.

cc/ @wonderfly @fabioy FYI

@andyzheng0831
Copy link
Author

Here is the e2e results. I tried a cluster with master and nodes on trusty, and also a cluster with only master on trusty. The results are the same:

[Fail] [k8s.io] Addon update [BeforeEach] should propagate add-on file changes
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/addon_update.go:358

Ran 161 of 268 Specs in 4306.137 seconds
FAIL! -- 160 Passed | 1 Failed | 0 Pending | 107 Skipped --- FAIL: TestE2E (4306.50s)

This failure is a known issue #23221 and I am working on it.

@andyzheng0831
Copy link
Author

@Q-Lee , this fix is due to the change in #22893. Next time if you rename/add/remove a variable in the manifest, please change cluster/gce/trusty/configure-helper.sh also, or cc me and I will fix it. The comments of #22893 says the heapster change targets for 1.2.1, but I don't see it has a cherrypick-candidate label. May I know the latest status? If you decide to make it in 1.2.1, I have to cherry pick this fix also. Please notify me when you decide to cherry pick. Thanks.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 24, 2016

GCE e2e build/test passed for commit bfd68b3.

@dchen1107 dchen1107 self-assigned this Mar 24, 2016
@dchen1107
Copy link
Member

LGTM

@dchen1107 dchen1107 added this to the v1.2 milestone Mar 24, 2016
@dchen1107 dchen1107 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cherrypick-candidate labels Mar 24, 2016
@dchen1107 dchen1107 removed this from the v1.2 milestone Mar 24, 2016
@wojtek-t
Copy link
Member

@fgrzadkowski @piosz @mwielgus - FYI

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit bfd68b3.

@andyzheng0831
Copy link
Author

@k8s-bot unit test this issue: #19268

@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit bfd68b3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@andyzheng0831
Copy link
Author

The PR #22893 breaking us was just cherry picked in release-1.2 branch. Accordingly, we need to cherry pick this fix too. We need to do it ASAP, otherwise we may miss 1.2.2 release

@k8s-oncall, please add "cherrypick-candidate" and "release-note" labels to this PR. I don't have permission to do it.

@zmerlynn zmerlynn added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 7, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@zmerlynn zmerlynn added this to the v1.2 milestone Apr 7, 2016
roberthbailey added a commit that referenced this pull request Apr 7, 2016
…34-upstream-release-1.2

Automated cherry pick of #23434
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ck-of-#23434-upstream-release-1.2

Automated cherry pick of kubernetes#23434
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…ck-of-#23434-upstream-release-1.2

Automated cherry pick of kubernetes#23434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants