Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

ok to test

I'm going to re-assign to justin. It is 'fine' in my eyes. I don't like the whole base/cidr implementation and don't love exposing that to a user. Then again, I don't use the AWS stuff, so I'm not going to force 3 env vars that suit my tastes.

I think it's better to just expose VPC_CIDR and SUBNET_CIDR as environment variable here instead of VPC_CIDR_BASE. Because what if someone else want to change vpc cidr suffix, do we need to add another variable VPC_CIDR_SUFFIX and let users configure it.
So I'd suggest to change these lines to

MASTER_IP_SUFFIX=.9   # Currently I'm not sure if this is important and configurable
VPC_CIDR=${VPC_CIDR:-172.20.0.0/16}
SUBNET_CIDR=${SUBNET_CIDR:-172.20.0.0/24}

Agree with @dengshuan so that the cidr range can be adjusted. Would be nice to get this released as currently sed'ing the files.

After looking at this closer, it should ideally aid in configuring the following... otherwise a number of other issues will occur. At least it should be added to the documentation.

export NON_MASQUERADE_CIDR="172.16.0.0/14"
export SERVICE_CLUSTER_IP_RANGE="172.16.0.0/16"
export DNS_SERVER_IP="172.16.0.10"
export MASTER_IP_RANGE="172.17.0.0/24"
export CLUSTER_IP_RANGE="172.18.0.0/16"

I think this is the right place to start; we'll consider it experimental for the moment, but people do need this.

GCE e2e build/test passed for commit 485aa7f.

• Build Log
• Test Artifacts
• Internal Jenkins Results