Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serve_hostname private authenticated test tag in Makefile #23289

Merged
merged 1 commit into from
Mar 26, 2016
Merged

Update serve_hostname private authenticated test tag in Makefile #23289

merged 1 commit into from
Mar 26, 2016

Conversation

pwittrock
Copy link
Member

No description provided.

@pwittrock
Copy link
Member Author

@bprashanth Do you know how to login to gcr and who should have perms to push images? I don't think I have the necessary permissions.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit 15344c3ac8fce7fa39153b46692fc2b697af886d.

@pwittrock pwittrock mentioned this pull request Mar 21, 2016
Closed
@pwittrock pwittrock force-pushed the move-serve-hostname branch from 15344c3 to d1d6650 Compare March 21, 2016 20:54
@pwittrock pwittrock changed the title Remove test tag from serve_hostname Makefile Update serve_hostname private authenticated test tag in Makefile Mar 21, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit d1d6650.

@bprashanth
Copy link
Contributor

Is this needed (we had a conversation but didn't conclusively determine anything, right?)

@ghost
Copy link

ghost commented Mar 22, 2016

Nuke, I think
On Mar 21, 2016 7:08 PM, "Prashanth B" notifications@github.com wrote:

Is this needed (we had a conversation but didn't conclusively determine
anything, right?)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#23289 (comment)

@pwittrock
Copy link
Member Author

Needed for these 2 tests:

kubernetes/test/e2e/replica_set.go

Line 45 in da58256

ReplicaSetServeImageOrFail(framework, "private", "b.gcr.io/k8s_authenticated_test/serve_hostname:v1.4")

kubernetes/test/e2e/rc.go

Line 43 in da58256

ServeImageOrFail(framework, "private", "b.gcr.io/k8s_authenticated_test/serve_hostname:v1.4")

Created #23391 for migrating to from b.gcr.io to gcr.io

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 24, 2016

GCE e2e build/test passed for commit d1d6650.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit d1d6650.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit d1d6650.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 25d94e8 into kubernetes:master Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bprashanth bprashanth

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pwittrock @k8s-github-robot @k8s-bot @bprashanth @k8s-teamcity-mesosphere @googlebot