Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kube-system namespace #23250

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Use kube-system namespace #23250

merged 1 commit into from
Apr 26, 2016

Conversation

huggsboson
Copy link
Contributor

Fixes #23153.

Sadly, kube-system isn't automatically created, so people need to make
sure to create it in their turnup scripts. Also after creating
kube-system it can take 10+ seconds for master and proxy to show up.

I tested the equivalent of these changes locally, but not these changes
themselves as I don't have a dev/build env up, so please read carefully
and maybe try them out!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Mar 20, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Mar 20, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Mar 20, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2016
@huggsboson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

luxas
luxas reviewed Mar 21, 2016
View reviewed changes
cluster/images/hyperkube/turnup.sh
sleep 1
done

kubectl create -f - << EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl create ns kube-system

@huggsboson
Copy link
Contributor Author

@luxas done.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2016
@colemickens
Copy link
Contributor

@huggsboson The kubernetes service remains in the default namespace. (per @thockin in Slack). So your last commit is not correct.

@huggsboson
Copy link
Contributor Author

Fixed. I'm obviously not really testing.

Here was the chat log:
colemickens @huggsboson: so, weird issue here. The DNS pod fails when I changed the nslookup to use kube-system instead of default. And, the kubernetes service shows up with kubectl get services, as in, it's in the default namespace still..
thockin: colemickens: the kubernetes service is supposed to be in default

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2016
@davidopp davidopp assigned mikedanese and unassigned davidopp Mar 29, 2016
@mikedanese
Copy link
Member

Please squash.

@huggsboson
Fixes kubernetes#23153.
99c79d1 
Sadly, kube-system isn't automatically created, so people need to make
sure to create it in their turnup scripts.  Also after creating
kube-system it can take 10+ seconds for master and proxy to show up.

I tested the equivalent of these changes locally, but not these changes
themselves as I don't have a dev/build env up, so please read carefully
and maybe try them out!

Use kubectl create ns
@huggsboson
Copy link
Contributor Author

squashed.

@luxas luxas added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 24, 2016
@luxas
Copy link
Member

luxas commented Apr 24, 2016

ping @mikedanese

@luxas luxas mentioned this pull request Apr 24, 2016
Closed
mikedanese
mikedanese reviewed Apr 25, 2016
View reviewed changes
cluster/images/hyperkube/turnup.sh
@@ -20,7 +20,7 @@ set -o errexit
set -o nounset
set -o pipefail

K8S_VERSION=${K8S_VERSION:-"1.2.0-alpha.7"}
K8S_VERSION=${K8S_VERSION:-"1.2.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doomed to be out of dat forever. We should avoid embedding k8s_version into scripts and instead discover the most recent

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Apr 25, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

GCE e2e build/test passed for commit 99c79d1.

@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

GCE e2e build/test passed for commit 99c79d1.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 26, 2016

GCE e2e build/test passed for commit 99c79d1.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1cd93cb into kubernetes:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@huggsboson @googlebot @k8s-bot @colemickens @mikedanese @luxas @k8s-github-robot @k8s-teamcity-mesosphere @davidopp