Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the restart-kube-proxy and restart-apiserver functions #23180

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Remove the restart-kube-proxy and restart-apiserver functions #23180

merged 1 commit into from
Mar 22, 2016
+1 −67

Conversation

roberthbailey
Copy link
Contributor

These were previously used by some of our shell e2e tests but appear to now be dead code. The functions to restart the kube-proxy are now wrong anyway, because in 1.2 kube-proxy runs in a container so sudo /etc/init.d/kube-proxy restart won't have any affect.

/cc @karlkfi @justinsb @derekwaynecarr

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit c5ca042.

@roberthbailey roberthbailey mentioned this pull request Mar 20, 2016
Merged
@roberthbailey roberthbailey added this to the v1.2 milestone Mar 20, 2016
@derekwaynecarr
Copy link
Member

LGTM

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2016
@zmerlynn
Copy link
Member

LGTM

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit c5ca042.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test failed for commit c5ca042.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@zmerlynn
Copy link
Member

@k8s-bot test this, issue #22671

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit c5ca042.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit c5ca042.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit c5ca042.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit c5ca042.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 22, 2016
Merge pull request #23180 from roberthbailey/dead-code
f2d1499 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit f2d1499 into kubernetes:master Mar 22, 2016
@bgrant0607
Copy link
Member

@roberthbailey This just looks like cleanup. Why is it a cherrypick candidate?

@roberthbailey
Copy link
Contributor Author

It is a cleanup, but the code on the branch is useless (and broken if anyone tries to use it). It's probably ok if it doesn't get cherry picked, but it seemed like it would hurt.

@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 23, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 24, 2016
@eparis
Merge pull request kubernetes#23180 from roberthbailey/dead-code
928f581 
Auto commit by PR queue bot
(cherry picked from commit f2d1499)
@eparis eparis mentioned this pull request Mar 24, 2016
Merged
@bgrant0607 bgrant0607 added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 24, 2016
@k8s-cherrypick-bot
Copy link

Commit 928f581 found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this s an error find help to get your PR picked.

AlainRoy pushed a commit to vmware-archive/kubernetes-archived that referenced this pull request Mar 29, 2016
Merge pull request kubernetes#23180 from roberthbailey/dead-code
1950a27 
Auto commit by PR queue bot
(cherry picked from commit f2d1499)
alena1108 pushed a commit to rancher/kubernetes that referenced this pull request May 20, 2016
Merge pull request kubernetes#23180 from roberthbailey/dead-code
e11d333 
Auto commit by PR queue bot
(cherry picked from commit f2d1499)
@roberthbailey roberthbailey deleted the dead-code branch May 23, 2016 17:44
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@eparis
Merge pull request kubernetes#23180 from roberthbailey/dead-code
916b68f 
Auto commit by PR queue bot
(cherry picked from commit f2d1499)
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@eparis
Merge pull request kubernetes#23180 from roberthbailey/dead-code
6ee4ba2 
Auto commit by PR queue bot
(cherry picked from commit f2d1499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
10 participants
@roberthbailey @k8s-github-robot @k8s-bot @derekwaynecarr @zmerlynn @bgrant0607 @k8s-cherrypick-bot @k8s-teamcity-mesosphere @googlebot @brendandburns