-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MESOS: forward globally declared cadvisor housekeeping flags #22974
MESOS: forward globally declared cadvisor housekeeping flags #22974
Conversation
Labelling this PR as size/M |
GCE e2e build/test passed for commit 622a28c. |
FWIW cadvisor flags are deprecated #19432 |
I think this changes work for me. Here is how I tried it:
I0316 01:50:42.370195 47 service.go:503] prepared executor command "./km" with args '[./km minion --run-proxy=true --proxy- I'm not sure how to check minion/server.go log, else, I can probably validate this line too:
|
you can look at the stderr of the mesos sandbox that's running the On Tue, Mar 15, 2016 at 10:23 PM, Lin Sun notifications@github.com wrote:
|
@jdef, I'm hitting an environmental issue where the executor on the host times out when downloading the km binary... seems the timeout is 1 min. trying to see if i can increase the network speed or tune the 1 min timeout value. |
try the On Wed, Mar 16, 2016 at 11:05 AM, Lin Sun notifications@github.com wrote:
|
Sorry for the delay. I updated the network speed of the env, and the stderr log looks good: I0317 03:08:12.063347 2850 task.go:220] starting task process "/opt/ibm/mesos/work/slaves/d58a68eb-5105-4be7-9ae8-577d5b24e9b2-S0/frameworks/d58a68eb-5105-4be7-9ae8-577d5b24e9b2-0001/executors/6d493c88c0ac86b3_k8sm-executor/runs/22ac059b-19ff-4ada-bc4d-65db178f3235/km" with args '[executor --api-servers=10.143.100.223:8888 --v=0 --allow-privileged=false --suicide-timeout=20m0s --mesos-launch-grace-period=5m0s --cadvisor-port=4194 --sync-frequency=10s --enable-debugging-handlers=true --cluster-dns=10.10.10.10 --cluster-domain=cluster.local --hostname-override=10.143.100.238 --kubelet-cgroups= --cgroup-root=/mesos/22ac059b-19ff-4ada-bc4d-65db178f3235 --housekeeping_interval=50s --global_housekeeping_interval=1m40s]' |
great. i'll mark this as mergeable. we missed the 1.2 cutoff, but this can On Wed, Mar 16, 2016 at 11:12 PM, Lin Sun notifications@github.com wrote:
|
Automatic merge from submit-queue |
…lags Auto commit by PR queue bot
@jdef Why would you like this to be cherrypicked into 1.2? |
Some folks from IBM are doing some performance work and want the ability to What's the criteria for getting things cherrypicked into 1.2? On Wed, Mar 23, 2016 at 6:23 PM, Brian Grant notifications@github.com
|
…ekeeping-flags Auto commit by PR queue bot (cherry picked from commit 68892a3)
Commit 50b41b6 found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this s an error find help to get your PR picked. |
…ekeeping-flags Auto commit by PR queue bot (cherry picked from commit 68892a3)
…ekeeping-flags Auto commit by PR queue bot (cherry picked from commit 68892a3)
…ekeeping-flags Auto commit by PR queue bot (cherry picked from commit 68892a3)
…ekeeping-flags Auto commit by PR queue bot (cherry picked from commit 68892a3)
xref #20331 (comment)
/cc @linsun