Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subPath to mount a child dir or file of a volumeMount #22575

Merged
merged 2 commits into from
May 8, 2016
Merged

Add subPath to mount a child dir or file of a volumeMount #22575

merged 2 commits into from
May 8, 2016

Conversation

mcluseau
Copy link
Contributor

@mcluseau mcluseau commented Mar 5, 2016 •
edited
Loading

Allow users to specify a subPath in Container.volumeMounts so they can use a single volume for many mounts instead of creating many volumes. For instance, a user can now use a single PersistentVolume to store the Mysql database and the document root of an Apache server of a LAMP stack pod by mapping them to different subPaths in this single volume.

Also solves #20466.

@k8s-bot
Copy link

k8s-bot commented Mar 5, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Mar 5, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Mar 5, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2016
@mcluseau
Copy link
Contributor Author

mcluseau commented Mar 7, 2016

/unbury @thockin ;)

@erictune
Copy link
Member

@ixdy unsubstituted variable in k8s-bot comments above.

@erictune erictune assigned thockin and unassigned erictune Mar 10, 2016
@rootfs
Copy link
Contributor

rootfs commented Mar 14, 2016

@MikaelCluseau your generated code is not there, run hack/update-all.sh and then hack/verify-all.sh

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2016
@mcluseau
Copy link
Contributor Author

Added the API change correctly.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2016
@mcluseau mcluseau force-pushed the wip-issue-20466 branch 2 times, most recently from 60d6482 to 0033f60 Compare March 15, 2016 03:59
@mcluseau
Copy link
Contributor Author

Travis build finished on error but the log shows a success. Mesos is ok. My own verify-all was ok too.

SUCCESS  hack/../hack/verify-flags-underscore.py    17s

make: *** [verify] Error 1

@mcluseau mcluseau force-pushed the wip-issue-20466 branch from cc0a8d6 to 4657d3a Compare May 3, 2016 05:10
@mcluseau
Copy link
Contributor Author

mcluseau commented May 3, 2016 •
edited
Loading

@thockin if I did it right, it should be the last round :-)

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2016
@thockin
Copy link
Member

thockin commented May 3, 2016

L

G

T

M

Thanks

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2016
@mcluseau mcluseau force-pushed the wip-issue-20466 branch from 4657d3a to 4c2dc56 Compare May 6, 2016 04:40
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 6, 2016
@bgrant0607 bgrant0607 assigned thockin and unassigned bgrant0607 May 7, 2016
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2016
@k8s-bot
Copy link

k8s-bot commented May 8, 2016

GCE e2e build/test passed for commit 4c2dc56.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 8, 2016

GCE e2e build/test passed for commit 4c2dc56.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f2f3b49 into kubernetes:master May 8, 2016
@yifan-gu yifan-gu mentioned this pull request Jun 21, 2016
Closed
@dshulyak dshulyak mentioned this pull request Jul 20, 2016
Closed
dshulyak added a commit to dshulyak/kubernetes.github.io that referenced this pull request Jul 20, 2016
@dshulyak
Add example mounting ConfigMap as a single file into /etc dir
d58ba7b 
ref: kubernetes/kubernetes#22575
@dshulyak dshulyak mentioned this pull request Jul 20, 2016
Merged
@astefanutti astefanutti mentioned this pull request Jul 21, 2016
Closed
@ravishivt ravishivt mentioned this pull request Jan 18, 2017
Merged
@astefanutti astefanutti mentioned this pull request Mar 13, 2019
Merged
@mcluseau mcluseau mentioned this pull request Feb 9, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mcluseau @k8s-bot @erictune @rootfs @tristanz @thockin @apatil @k8s-github-robot @googlebot @bgrant0607