Regional registries: Hack the manifests! #22571
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e build/test failed for commit bb1b58596ee2e5fc0499f2063f4c02b606011ff2. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
Allow the gcr.io/google_containers registry to be overridden regionally by just blasting a new KUBE_ADDON_REGISTRY out. Instead of adding every addon to Salt and asking all of the other consumers (Trusty, Juju, Mesos, etc) to change, just script the sed ourselves. This is probably the 9th grossest thing I've ever done, but it works well, and it works quickly. I kind of wish it didn't.
zmerlynn
force-pushed
the
regional-registry
branch
from
bb1b585 to
60e1fcc
Compare
|
GCE e2e build/test passed for commit 60e1fcc. |
roberthbailey
added
cherrypick-candidate
lgtm
|
/cc @andyzheng0831 -- I think we've done this in a way that won't break trusty, but cc'ing you just so you are aware of what we are changing. |
|
@roberthbailey, thanks for heads-up. This won't break our trusty stuff, but the new logic is not supported there automatically. I think what I need to change is very similar to the change of cluster/saltbase/install.sh in this PR, i.e., if ${KUBE_ADDON_REGISTRY} is different from gcr.io/google_containers we use the regional registry. I will make the change by noon of Monday before leaving for offsite. |
|
@zmerlynn @roberthbailey , what is the difference between KUBE_DOCKER_REGISTRY and KUBE_ADDON_REGISTRY? If both are set, which one overwrites which? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 60e1fcc. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
|
@andyzheng0831: It's complicated. Neither should overwrite the other. |
|
@zmerlynn , got you. My change follows the same logic as what you explained. |
Allow the
gcr.io/google_containersregistry to be overridden regionally by just blasting a new KUBE_ADDON_REGISTRY out. Instead of adding every addon to Salt and asking all of the other consumers (Trusty, Juju, Mesos, etc) to change, just script the sed ourselves.This is probably the 9th grossest thing I've ever done, but it works well, and it works quickly. I kind of wish it didn't.