Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname #22564

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname #22564

merged 1 commit into from
Mar 11, 2016

Conversation

ArtfulCoder
Copy link
Contributor

…

@ArtfulCoder ArtfulCoder added this to the v1.2 milestone Mar 4, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 4, 2016

GCE e2e build/test passed for commit 21a303dee9064640435110c806c9e9a3161b85b3.

thockin
thockin reviewed Mar 4, 2016
View reviewed changes
cluster/addons/dns/README.md
@@ -59,6 +59,21 @@ When enabled, pods are assigned a DNS A record in the form of `pod-ip-address.my

For example, a pod with ip `1.2.3.4` in the namespace `default` with a dns name of `cluster.local` would have an entry: `1-2-3-4.default.pod.cluster.local`.


####A Records and hostname Based on Pod Annotations - A Beta Feature in Kubernetes v1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.2 not v1.3 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ArtfulCoder ArtfulCoder force-pushed the dnsdoc branch 3 times, most recently from 911b6e0 to 66f5d15 Compare March 8, 2016 02:29
@ArtfulCoder
Copy link
Contributor Author

PTAL

@k8s-bot
Copy link

k8s-bot commented Mar 8, 2016

GCE e2e build/test passed for commit 6070e84e30cdb372304ba1567236664a50590095.

@k8s-bot
Copy link

k8s-bot commented Mar 8, 2016

GCE e2e build/test passed for commit 66f5d152008bc3ca50d21bb4f5aa0ce27f2e87c6.

@k8s-bot
Copy link

k8s-bot commented Mar 8, 2016

GCE e2e build/test passed for commit 911b6e097cfdf7121456226273fa801bbf59fe81.

@k8s-bot
Copy link

k8s-bot commented Mar 8, 2016

GCE e2e build/test passed for commit 11327de.

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test failed for commit 11327de.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@ArtfulCoder ArtfulCoder mentioned this pull request Mar 11, 2016
Merged
@bgrant0607
Copy link
Member

DNS needs a doc in the doc repo.

@bgrant0607 bgrant0607 added e2e-not-required cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
@bgrant0607
Copy link
Member

e2e flaked, but this is a doc change. Manually merging. @k8s-oncall

bgrant0607 added a commit that referenced this pull request Mar 11, 2016
@bgrant0607
Merge pull request #22564 from ArtfulCoder/dnsdoc
1a1a77d 
Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname
@bgrant0607 bgrant0607 merged commit 1a1a77d into kubernetes:master Mar 11, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22564 from ArtfulCoder/dnsdoc
ef3e704 
Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname
@eparis eparis mentioned this pull request Mar 11, 2016
Merged
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR is included in #22874 which is slated to be included in the release-1.2 branch.
Please verify that the cherry-pick in that PR looks correct.

@eparis eparis removed cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
@ArtfulCoder ArtfulCoder mentioned this pull request Apr 15, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 29, 2016
Merge pull request #24362 from ArtfulCoder/hostname-field
ad67363 
Automatic merge from submit-queue

Promote Pod Hostname & Subdomain to fields (were annotations)

Deprecating the podHostName, subdomain and PodHostnames annotations and created corresponding new fields for them on PodSpec and Endpoints types.

Annotation doc: #22564
Annotation code: #20688
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22564 from ArtfulCoder/dnsdoc
269cfff 
Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607 @eparis
Merge pull request kubernetes#22564 from ArtfulCoder/dnsdoc
87fbe95 
Update DNS document to talk about the new Pod and Endpoints Annotations to set hostname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ArtfulCoder @k8s-github-robot @k8s-bot @bgrant0607 @eparis @thockin @k8s-teamcity-mesosphere @googlebot