Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logging images to parse sub-second docker timestamps. #22074

Merged
merged 1 commit into from
Mar 4, 2016

Conversation

a-robinson
Copy link
Contributor

The configs were updated in #21482, this is just updating the images, which I've pushed.

cc @chrisleck

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 26, 2016

GCE e2e build/test passed for commit 4d87e543252ce94dc6519f3e87d6a0c288ef31f0.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2016
@a-robinson a-robinson assigned fabioy and unassigned brendandburns Feb 26, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 26, 2016

GCE e2e build/test failed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@chris-codaio
Copy link
Contributor

FYI - it looks like some logs are now parsed correctly, but the fluent-plugin-kubernetes_metadata_filter plugin is stripping milliseconds now...sigh.

@fabioy fabioy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2016
@fabioy
Copy link
Contributor

fabioy commented Feb 26, 2016

The change itself seems innocuous -- I'm assuming here the new versions fix the issue.

@a-robinson
Copy link
Contributor Author

Huh. @jimmidyson, is stripping milliseconds in the metadata filter plugin expected?

@jimmidyson
Copy link
Member

Not at all. Fluentd only supports second resolution of log events, although subsecond precision is now supported in fluentd v0.14.0.pre.1 & master.

The metadata filter plugin shouldn't strip anything, but is only able to use subsecond precision of fluentd itself supports it.

@k8s-github-robot
Copy link

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6.

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 2, 2016

GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@eparis
Copy link
Contributor

eparis commented Mar 3, 2016

jenkins has screwed up, this PR is now stuck. #22435

Thus far the best way I've seen to get it unstuck is to make a tiny change. repush, and re-add LGTM. Sorry :-(

@a-robinson
Copy link
Contributor Author

Thanks @eparis, done.

@a-robinson a-robinson added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 3, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 3, 2016

GCE e2e build/test passed for commit feea376.

a-robinson added a commit that referenced this pull request Mar 4, 2016
Update the logging images to parse sub-second docker timestamps.
@a-robinson a-robinson merged commit 29eb602 into kubernetes:master Mar 4, 2016
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 25, 2019
…cs-typo

UPSTREAM: 74244: kube-aggregator: fix typo aggregator_unavailable_api{server -> service}_gauge

Origin-commit: 4bcbaf18fa3a82d4b09b091bf4eb1407f0694f69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants