-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the logging images to parse sub-second docker timestamps. #22074
Conversation
Labelling this PR as size/XS |
GCE e2e build/test passed for commit 4d87e543252ce94dc6519f3e87d6a0c288ef31f0. |
Labelling this PR as size/S |
GCE e2e build/test failed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
FYI - it looks like some logs are now parsed correctly, but the fluent-plugin-kubernetes_metadata_filter plugin is stripping milliseconds now...sigh. |
The change itself seems innocuous -- I'm assuming here the new versions fix the issue. |
Huh. @jimmidyson, is stripping milliseconds in the metadata filter plugin expected? |
Not at all. Fluentd only supports second resolution of log events, although subsecond precision is now supported in fluentd v0.14.0.pre.1 & master. The metadata filter plugin shouldn't strip anything, but is only able to use subsecond precision of fluentd itself supports it. |
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6. |
GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6. |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e build/test passed for commit 03bb610df9582932dfb93d6d2fe2fad8c004d4b6. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
jenkins has screwed up, this PR is now stuck. #22435 Thus far the best way I've seen to get it unstuck is to make a tiny change. repush, and re-add LGTM. Sorry :-( |
Thanks @eparis, done. |
GCE e2e build/test passed for commit feea376. |
Update the logging images to parse sub-second docker timestamps.
…cs-typo UPSTREAM: 74244: kube-aggregator: fix typo aggregator_unavailable_api{server -> service}_gauge Origin-commit: 4bcbaf18fa3a82d4b09b091bf4eb1407f0694f69
The configs were updated in #21482, this is just updating the images, which I've pushed.
cc @chrisleck