Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #21746 #21972

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Conversation

olivierlemasle
Copy link
Member

Fix issue #21746

This was a regression due to commit e2c79ea
(cf #20965)

This was a regression due to commit e2c79ea
(cf kubernetes#20965)
@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@olivierlemasle
Copy link
Member Author

I guess this commit will fix the error occuring with "kube-push" if the bearer token is already present, but it will not fix it the token was not present (if the cluster was created before e2c79ea was merged)

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2016
@derekwaynecarr
Copy link
Member

Taking this PR review since its vagrant...

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2016
@derekwaynecarr
Copy link
Member

Thanks for the PR. I verified this fixed kube-push.

@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

GCE e2e build/test failed for commit 08541dc.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@olivierlemasle
Copy link
Member Author

@k8s-bot test this issue: #21487

@olivierlemasle
Copy link
Member Author

@derekwaynecarr Could you please re-test this pull request?

@wojtek-t
Copy link
Member

@k8s-bot test this please github issue: #IGNORE (jenkins issues)

@k8s-bot
Copy link

k8s-bot commented Feb 28, 2016

GCE e2e build/test failed for commit 08541dc.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@0xmichalis
Copy link
Contributor

I can confirm this fixes kube-push.sh. Thanks.

@derekwaynecarr
Copy link
Member

@k8s-bot test this please github issue: #IGNORE (jenkins issues)

@k8s-bot
Copy link

k8s-bot commented Mar 3, 2016

GCE e2e build/test passed for commit 08541dc.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 4, 2016
@k8s-github-robot k8s-github-robot merged commit 49f438b into kubernetes:master Mar 4, 2016
@olivierlemasle olivierlemasle deleted the fix-21746 branch March 4, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants