-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #21746 #21972
Fix issue #21746 #21972
Conversation
This was a regression due to commit e2c79ea (cf kubernetes#20965)
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
I guess this commit will fix the error occuring with "kube-push" if the bearer token is already present, but it will not fix it the token was not present (if the cluster was created before e2c79ea was merged) |
Labelling this PR as size/XS |
Taking this PR review since its vagrant... |
Thanks for the PR. I verified this fixed kube-push. |
GCE e2e build/test failed for commit 08541dc. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
@derekwaynecarr Could you please re-test this pull request? |
@k8s-bot test this please github issue: #IGNORE (jenkins issues) |
GCE e2e build/test failed for commit 08541dc. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
I can confirm this fixes kube-push.sh. Thanks. |
@k8s-bot test this please github issue: #IGNORE (jenkins issues) |
GCE e2e build/test passed for commit 08541dc. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Fix issue #21746
This was a regression due to commit e2c79ea
(cf #20965)