Remove 'be formatted' from VolumeSource docs #21884
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
kind/api-change
|
@bgrant0607 PTAL |
|
GCE e2e test build/test passed for commit 6b4dc00f6152354e917cf1d6f469b25188c3207b. |
| // GCE PDs support ownership management and SELinux relabeling. | ||
| // A GCE PD must exist before mounting to a container. The disk must | ||
| // also be in the same GCE project and zone as the kubelet. A GCE PD | ||
| // can only be mounted as read/write once. GCE PDs support ownership |
There was a problem hiding this comment.
can only be mounted as read/write once
While, we're cleaning up the comments, this doesn't seem right. GCE PDs can be mounted as read-only as well right? Ditto for AWS below?
saad-ali
changed the title
|
@saad-ali updated GCE comment. I think AWS EBS is correct |
|
GCE e2e test build/test passed for commit cb21e286c36ad7f5690fc81cfa39df52c3240329. |
Volumes do not need to be formatted as we now have the SafeFormatAndMount utility which formats volumes when needed.
|
GCE e2e build/test failed for commit d7c6eb9. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
|
LGTM thanks @swagiaal |
saad-ali
added
lgtm
Remove 'be formatted' from VolumeSource docs
|
@fabioy this was failing verification checks and should not have been merged. |
|
Yeah, I missed it (my bad). I've since updated docs on another PR. |
|
Hmm.. sorry about that guys! |
|
Yeah, it's not in the "Build Log" link above, but the Jenkins output. But, if you build locally, it'll show an error in the generated doc: Moving api reference docs from /workspace/kubernetes/_output/generated_html to /workspace/kubernetes/tmp/api-reference Represents a Persistent Disk resource in Google Compute Engine.
-
diff -NauprB -I 'Last update' '--exclude=_.md' /workspace/kubernetes/docs/api-reference/v1/definitions.html /workspace/kubernetes/_tmp/api-reference/v1/definitions.html
--- /workspace/kubernetes/docs/api-reference/v1/definitions.html 2016-02-26 13:34:34.047480330 -0800
+++ /workspace/kubernetes/_tmp/api-reference/v1/definitions.html 2016-02-26 13:38:28.151607127 -0800
@@ -982,7 +982,7 @@ Examples:A GCE PD must exist before mounting to a container. The disk must also be in the same GCE project and zone as the kubelet. A GCE PD can only be mounted as read/write once. GCE PDs support ownership management and SELinux relabeling. +A GCE PD must exist before mounting to a container. The disk must also be in the same GCE project and zone as the kubelet. A GCE PD can only be mounted as read/write once or read-only many times. GCE PDs support ownership management and SELinux relabeling. Represents a Persistent Disk resource in Google Compute Engine.
- A GCE PD must exist before mounting to a container. The disk must also be in the same GCE project and zone as the kubelet. A GCE PD can only be mounted as read/write once. GCE PDs support ownership management and SELinux relabeling. +A GCE PD must exist before mounting to a container. The disk must also be in the same GCE project and zone as the kubelet. A GCE PD can only be mounted as read/write once or read-only many times. GCE PDs support ownership management and SELinux relabeling. |
Volumes do not need to be formatted as we now have the
SafeFormatAndMount utility which formats volumes when needed.