Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-linkchecker.sh now exits with a non-zero return code if found invalid links #21822

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

caesarxuchao
Copy link
Member

With this fix Jenkins will send email to me if linkchecker finds invalid links.

fi

trap "cleanup" EXIT SIGINT
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplication of line 32.

@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e build/test failed for commit b9a350a.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2016
@caesarxuchao
Copy link
Member Author

@k8s-bot e2e test this, issue: #21836

@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit b9a350a.

@ixdy
Copy link
Member

ixdy commented Feb 24, 2016

LGTM

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2016
@caesarxuchao
Copy link
Member Author

I'm going to manually merge it. It doesn't affect the production code.

caesarxuchao added a commit that referenced this pull request Feb 24, 2016
verify-linkchecker.sh now exits with a non-zero return code if found invalid links
@caesarxuchao caesarxuchao merged commit e113aef into kubernetes:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants