Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the EventSink in HPA controller #21816

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Fix the EventSink in HPA controller #21816

merged 1 commit into from
Feb 24, 2016

Conversation

caesarxuchao
Copy link
Member

Fix #21763.

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 24, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2016
@caesarxuchao caesarxuchao mentioned this pull request Feb 24, 2016
Closed
@caesarxuchao
Copy link
Member Author

@piosz could you double check if this fixes the issue? I don't know how to reproduce the problem you reported.

@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit e20e295.

@piosz
Copy link
Member

piosz commented Feb 24, 2016

LGTM
Thanks for the fix! I'll check today.

@piosz piosz added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 24, 2016
@piosz
Copy link
Member

piosz commented Feb 24, 2016

I can confirm that this fixed the problem.

@caesarxuchao
Copy link
Member Author

Thanks @piosz for the confirmation :)

@caesarxuchao
Copy link
Member Author

Manually merging.

caesarxuchao added a commit that referenced this pull request Feb 24, 2016
@caesarxuchao
Merge pull request #21816 from caesarxuchao/fix-21763
cf98bcb 
Fix the EventSink in HPA controller
@caesarxuchao caesarxuchao merged commit cf98bcb into kubernetes:master Feb 24, 2016
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Jan 28, 2019
@k8s-publishing-bot
Merge pull request kubernetes#21816 from juanvallejo/jvallejo/make-ap…
ccf3c9a 
…iresource-discovery-non-fatal

UPSTREAM: 73035: make api-resource discovery errors non-fatal

Origin-commit: 4e4d37ba14edf356eced5d8e77a81788c2a79ccd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@caesarxuchao @k8s-github-robot @k8s-bot @piosz @k8s-teamcity-mesosphere @googlebot