Set RC's pod template TerminationGracePeriodSeconds to 0 in test-cmd.sh test data #21793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetkuo
added
priority/important-soon
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
| app: guestbook | ||
| tier: frontend | ||
| spec: | ||
| terminationGracePeriodSeconds: 0 |
There was a problem hiding this comment.
Maybe add a comment about why this is set?
|
GCE e2e build/test failed for commit 54540105f438a21535b621f874cb97ceec4317dc. |
janetkuo
force-pushed
the
test-cmd-delete-flake
branch
from
5454010 to
dbfb6c0
Compare
|
Per in-person discussion with @caesarxuchao, |
|
GCE e2e test build/test passed for commit dbfb6c0. |
No, per in-person discussion with @bgrant0607, we should stay with setting |
|
template.spec.terminationGracePeriodSeconds is correct |
|
LGTM |
bgrant0607
added
the
lgtm
|
Thanks @bgrant0607. |
|
Merging |
bgrant0607
added a commit
that referenced
this pull request
Feb 24, 2016
Set RC's pod template TerminationGracePeriodSeconds to 0 in test-cmd.sh test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21716
Set pods' TerminationGracePeriodSeconds to 0 so that it'll be deleted immediately by
kubectl deleteto prevent test flake.cc @kubernetes/kubectl @kubernetes/goog-csi