-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flake in LimitRange e2e #21788
Fix flake in LimitRange e2e #21788
Conversation
/cc @ncdc |
Labelling this PR as size/XS |
To elaborate:
The fix is to not populate a live lookup cache until we see our first pod so live lookup cache is not prematurely updated when the limit range itself is created. |
GCE e2e test build/test passed for commit 4858b48. |
@derekwaynecarr good catch. Is this already in the origin pick list? |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit 4858b48. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
@deads2k - I added it to the issue list. |
GCE e2e build/test failed for commit 4858b48. |
GCE e2e test build/test passed for commit 4858b48. |
Fix flake in LimitRange e2e
Fixes #21234
The
LimitRange
TTL cache was being populated when theLimitRange
itself was being created which meant the cache was getting set to empty by default.The fix is that
LimitRange
should ignore things that are not pods prior to building its live look-up cache.