Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure etcd2 actually gets started #21772

Merged
merged 1 commit into from
Feb 26, 2016
Merged

Conversation

matthughes
Copy link
Contributor

This configures etcd2, but doesn't actually start it up. At least using the CoreOS Openstack image, nothing else was doing this.

This configures etcd2, but doesn't actually start it up.  At least using the CoreOS Openstack image, nothing else was doing this.
@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2016
@kelseyhightower
Copy link
Contributor

LGTM

@kelseyhightower kelseyhightower added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2016
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

GCE e2e build/test failed for commit ce6c87c.

@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@fabioy
Copy link
Contributor

fabioy commented Feb 26, 2016

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Feb 26, 2016

GCE e2e build/test passed for commit ce6c87c.

fabioy added a commit that referenced this pull request Feb 26, 2016
Make sure etcd2 actually gets started
@fabioy fabioy merged commit 465934f into kubernetes:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants