add readiness probe to proxy test #21730
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e build/test failed for commit 9d87b47. |
| Image: config.Image, | ||
| Command: config.Command, | ||
| Ports: []api.ContainerPort{{ContainerPort: 80}}, | ||
| ReadinessProbe: config.ReadinessProbe, |
There was a problem hiding this comment.
Don't we actually need to poll till Ready? Assuming if this method didn't know about readiness before it only polled till Running, but I haven't checked.
There was a problem hiding this comment.
One might think so, but it actually already has separate runningButNotReady and runningAndReady states that it prints out in the logs.
|
The e2e failure is #21769, in case you need a rerun without uploading a new commit |
|
Handing over to @bprashanth to review; hand back if you'd rather not. |
|
@k8s-bot test this flake #21769 (thx @bprashanth) |
bprashanth
added
the
lgtm
|
GCE e2e test build/test passed for commit 9d87b47. |
|
GCE e2e test build/test passed for commit 9d87b47. |
|
@k8s-oncall this is a flake fix, please manually merge |
1 similar comment
|
@k8s-oncall this is a flake fix, please manually merge |
add readiness probe to proxy test
Fixes #21484