Added JobTemplate, a preliminary step for ScheduledJob and Workflow #21675

soltysh · 2016-02-22T12:45:02Z

@sdminonne as promised, sorry it took this long 😊
@erictune fyi though it does not have to be in for 1.2

This change is

sdminonne · 2016-02-22T13:05:10Z

erictune · 2016-02-25T05:04:12Z

pkg/apis/batch/v1/types.go

+// JobTemplate describes a template for creating copies of a predefined pod.
+type JobTemplate struct {
+	unversioned.TypeMeta `json:",inline"`
+	v1.ObjectMeta        `json:"metadata,omitempty"`


use the same hyperlinks as PodTemplate comments

erictune · 2016-02-25T05:07:27Z

I suggest we wait for after 1.2 to merge this.

erictune · 2016-02-25T05:15:04Z

So, this PR seems fine.

I'm guessing the next PR is going to add "ScheduledJob". I am not sure where that goes.
I don't think it can go into batch/v1 since ScheduledJob won't be v1 on the first release.

I think what needs to happen is that we need to create a batch/v2alpha1 which has Job and ScheduledJob in it, and that group needs to advance through batch/v2beta1 and then batch/v2,
at which point ScheduledJob will be GA. During that time, Jobs will be accessible through 3 or more endpoints. It seems a bit complex, but I'm not sure what the alternative is.
@lavalamp @bgrant0607 @deads2k

By the way, it makes it kind of an incentive to get Workflow in at the same time as ScheduledJob, to avoid a v3alpha1.

soltysh · 2016-02-25T11:01:39Z

I suggest we wait for after 1.2 to merge this.

Yes, that was the point.

I think what needs to happen is that we need to create a batch/v2alpha1 which has Job and ScheduledJob in it

Why can't we just use Job from batch/v1 I'd personally stay away from creating Jobs in it.

Other silly question, instead of messing batch sub-group, can't we use extensions/v1beta1 or extensions/v2beta1 as the incubator for new types, since the internal is already in place. And then move to appropriate group only when GA?

soltysh · 2016-02-25T11:16:56Z

@erictune added the urls you've asked for.

sdminonne · 2016-02-25T13:02:13Z

@erictune @soltysh, I plan to submit a PR for workflow and for the moment it will be in pkg/apis/extensions/v1beta1 but I'm OK to modify according to other needs/policy

erictune · 2016-02-25T16:08:05Z

@bgrant0607 @lavalamp we need to decide what to do in this case:

we are introducing an alpha-version of a new Kind (e.g. ScheduledJob or Workflow)
we know already what the API group for the new kind it will eventually be (e.g. Batch)
there is already something in the eventual destination group (e.g. Job is already in Batch/v1).

Considerations:

extensions/v1beta1 is where we have been putting stuff, so it is easy/consistent to put new things there
but... extensions/v1beta1 was a hack for when we didn't have api groups working in general. we should stop using it now?
the internal for Job is in extensions/v1beta1, and so putting things that use it in extensions/v1beta1 is convenient
but... we have a plan to remove Job from there in version 1.4, and we would not be able to migrate ScheduledJob or Workflow out of extensions on the same schedule
assuming ScheduledJob or Workflow went into extensions first, and then was ready for GA, where does it go for GA? Batch/v1 or Batch/v2? The former makes sense because there is not any change to Job planned, so no need to rev the group for that. And it is less work. The latter makes sense since we once said that we would not add new things to an API group once it had been formed, so that users could use the presence of the api group to determine the presence of all enclosing kinds.

bgrant0607 · 2016-02-25T16:56:52Z

@erictune If there's nothing here that needs to be decided for 1.2, I'll have to look at this later.

erictune · 2016-02-25T17:06:00Z

no 1.2 issues.

lavalamp · 2016-02-25T18:55:31Z

Ping me again after 1.2 and I'll have lots to say. :)

On Thu, Feb 25, 2016 at 9:06 AM, Eric Tune notifications@github.com wrote:

no 1.2 issues.

—
Reply to this email directly or view it on GitHub
#21675 (comment)
.

sdminonne · 2016-03-10T13:20:28Z

@soltysh ping :)

lavalamp · 2016-03-16T21:54:50Z

I'm paying attention to PRs again. I will come back to this one once I triage my entire queue.

sdminonne · 2016-03-16T23:15:44Z

Thanks

soltysh · 2016-03-18T16:26:59Z

@lavalamp yeah, that will be needed for the scheduled jobs I'm hoping to start next week.

lavalamp · 2016-03-18T21:30:12Z

pkg/apis/batch/v1/types.go

+type JobTemplateSpec struct {
+	// Standard object's metadata.
+	// More info: http://releases.k8s.io/HEAD/docs/devel/api-conventions.md#metadata
+	v1.ObjectMeta `json:"metadata,omitempty"`


You should not need this except in top-level objects.

This is similar to PodTemplateSpec to allow us define created Job's metadata fields.

I'll update the comment to give my reasoning.

soltysh · 2016-03-22T15:23:05Z

@lavalamp removed from v1beta1 and updated the comments, ptal

lavalamp · 2016-03-23T00:11:33Z

@k8s-bot test this issue: #23365

OK, this LGTM.

soltysh · 2016-05-06T09:57:29Z

Sorry, forgot to run hack/update-all.sh.

soltysh · 2016-05-09T10:27:15Z

Rebased, I didn't forget to run hack/update-all.sh this time, so hopefully should be a green one. I've also updated defaults.go according to recent changes.
@erictune || @lavalamp mind re-adding the lgtm label.

soltysh · 2016-05-10T19:53:53Z

@erictune || @lavalamp mind re-adding the lgtm label, I'd like to avoid rebasing once again.

soltysh · 2016-05-11T07:21:07Z

@k8s-bot test this github issue: #24211

k8s-github-robot · 2016-05-11T08:58:46Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-05-11T09:31:17Z

GCE e2e build/test passed for commit a31ca0d.

k8s-github-robot · 2016-05-11T09:40:58Z

Automatic merge from submit-queue

soltysh · 2016-05-11T09:41:54Z

🎉

erictune · 2016-05-11T16:26:32Z

👍

@erictune

Automatic merge from submit-queue Scheduledjob api @erictune ScheduledJob api types, based on #21675, so only last two commits counts. @sdminonne fyi ```release-note Introducing ScheduledJobs as described in [the proposal](https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/scheduledjob.md) as part of `batch/v2alpha1` version (experimental feature). ``` [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()

UPSTREAM: 71074: fix device path being empty Origin-commit: f129e1f66f6da7a33f66d8382ab6b3341eccdf48

googlebot added the cla: yes label Feb 22, 2016

k8s-github-robot assigned lavalamp Feb 22, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2016

erictune reviewed Feb 25, 2016
View reviewed changes

soltysh force-pushed the job_template branch from cfa680e to 7f6e888 Compare February 25, 2016 11:16

lavalamp reviewed Mar 18, 2016
View reviewed changes

soltysh force-pushed the job_template branch from 7f6e888 to 2908168 Compare March 22, 2016 15:22

lavalamp added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 23, 2016

soltysh force-pushed the job_template branch from 5f5af92 to a0aa632 Compare May 6, 2016 09:57

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2016

soltysh force-pushed the job_template branch from a0aa632 to 00d387c Compare May 9, 2016 10:25

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2016

soltysh added 2 commits May 10, 2016 21:48

extensions -> batch internals move leftovers

de357fd

Added JobTemplate, a preliminary step for ScheduledJob and Workflow

5ef870d

soltysh force-pushed the job_template branch from 00d387c to cf50fd5 Compare May 10, 2016 19:53

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2016

soltysh added 2 commits May 10, 2016 22:40

Generated changes for batch/v2alpha1

df11a51

enable batch/v2alpha1 tests

a31ca0d

soltysh force-pushed the job_template branch from cf50fd5 to a31ca0d Compare May 10, 2016 20:40

erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 10, 2016

k8s-github-robot merged commit ef885d0 into kubernetes:master May 11, 2016

soltysh deleted the job_template branch May 11, 2016 09:44

soltysh mentioned this pull request May 13, 2016

Multiversion client tests #25566

Closed

soltysh mentioned this pull request Jul 4, 2016

CronJobs (previously ScheduledJobs) kubernetes/enhancements#19

Closed

16 tasks

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Jan 29, 2019

Merge pull request kubernetes#21675 from gnufied/fix-device-path-empty

b21b3d9

UPSTREAM: 71074: fix device path being empty Origin-commit: f129e1f66f6da7a33f66d8382ab6b3341eccdf48

alculquicondor mentioned this pull request Feb 27, 2023

remove ValidateJobTemplate and add more test cases to batch validation #116052

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added JobTemplate, a preliminary step for ScheduledJob and Workflow #21675

Added JobTemplate, a preliminary step for ScheduledJob and Workflow #21675

soltysh commented Feb 22, 2016 •

edited by mikedanese

Loading

sdminonne commented Feb 22, 2016

erictune Feb 25, 2016

erictune commented Feb 25, 2016

erictune commented Feb 25, 2016

soltysh commented Feb 25, 2016

soltysh commented Feb 25, 2016

sdminonne commented Feb 25, 2016

erictune commented Feb 25, 2016

bgrant0607 commented Feb 25, 2016

erictune commented Feb 25, 2016

lavalamp commented Feb 25, 2016

sdminonne commented Mar 10, 2016

lavalamp commented Mar 16, 2016

sdminonne commented Mar 16, 2016

soltysh commented Mar 18, 2016

lavalamp Mar 18, 2016

soltysh Mar 22, 2016

soltysh Mar 22, 2016

soltysh commented Mar 22, 2016

lavalamp commented Mar 23, 2016

soltysh commented May 6, 2016

soltysh commented May 9, 2016

soltysh commented May 10, 2016

soltysh commented May 11, 2016

k8s-github-robot commented May 11, 2016

k8s-bot commented May 11, 2016

k8s-github-robot commented May 11, 2016

soltysh commented May 11, 2016

erictune commented May 11, 2016

Added JobTemplate, a preliminary step for ScheduledJob and Workflow #21675

Added JobTemplate, a preliminary step for ScheduledJob and Workflow #21675

Conversation

soltysh commented Feb 22, 2016 • edited by mikedanese Loading

sdminonne commented Feb 22, 2016

erictune Feb 25, 2016

Choose a reason for hiding this comment

erictune commented Feb 25, 2016

erictune commented Feb 25, 2016

soltysh commented Feb 25, 2016

soltysh commented Feb 25, 2016

sdminonne commented Feb 25, 2016

erictune commented Feb 25, 2016

bgrant0607 commented Feb 25, 2016

erictune commented Feb 25, 2016

lavalamp commented Feb 25, 2016

sdminonne commented Mar 10, 2016

lavalamp commented Mar 16, 2016

sdminonne commented Mar 16, 2016

soltysh commented Mar 18, 2016

lavalamp Mar 18, 2016

Choose a reason for hiding this comment

soltysh Mar 22, 2016

Choose a reason for hiding this comment

soltysh Mar 22, 2016

Choose a reason for hiding this comment

soltysh commented Mar 22, 2016

lavalamp commented Mar 23, 2016

soltysh commented May 6, 2016

soltysh commented May 9, 2016

soltysh commented May 10, 2016

soltysh commented May 11, 2016

k8s-github-robot commented May 11, 2016

k8s-bot commented May 11, 2016

k8s-github-robot commented May 11, 2016

soltysh commented May 11, 2016

erictune commented May 11, 2016

soltysh commented Feb 22, 2016 •

edited by mikedanese

Loading