fix shadowing bug #21569
Merged
fix shadowing bug #21569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
GCE e2e test build/test passed for commit 43bf1eacb3da465a699178670a394bb9ab22460b. |
| Expect(err).NotTo(HaveOccurred()) | ||
| dumpAllNamespaceInfo(c, api.NamespaceSystem) | ||
| if c, errClient := loadClient(); errClient != nil { | ||
| Expect(errClient).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
probably don't need to if-guard this - Expect will bail out if it fails.
There was a problem hiding this comment.
Oh. I don't want that, then we never see the error. I'll make a change.
lavalamp
force-pushed
the
fix-shadowing
branch
from
43bf1ea to
d6c2d32
Compare
|
Labelling this PR as size/S |
k8s-github-robot
added
size/S
|
Fixed. PTAL |
| Expect(err).NotTo(HaveOccurred()) | ||
| dumpAllNamespaceInfo(c, api.NamespaceSystem) | ||
| if c, errClient := loadClient(); errClient != nil { | ||
| Logf("Unable to dump cluster information because: %v", err) |
|
GCE e2e test build/test passed for commit d6c2d322e1ea85c30a314470c632c34565775908. |
|
Flake is #21451 |
lavalamp
force-pushed
the
fix-shadowing
branch
from
d6c2d32 to
6afe858
Compare
|
Fixed comment, rebased. PTAL |
|
GCE e2e test build/test passed for commit 6afe858. |
|
LGTM |
ixdy
added
the
lgtm
|
@k8s-oncall this is a flake debugging helper, please manually merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21522 gave a useless message due to this.