Add DaemonSets and Deployments to valid resources list in kubectl. #21509
Conversation
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
| @@ -112,6 +112,8 @@ __custom_func() { | |||
| ` | |||
| valid_resources = `Valid resource types include: | |||
| * componentstatuses (aka 'cs') | |||
| * daemonsets (aka 'ds') | |||
| * deployments | |||
There was a problem hiding this comment.
Thanks. Could you also add an abbreviation for deployments? I propose 'dep'.
cc @Kargakis @janetkuo @mqliang
expandResourceShortcut:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/kubectl.go#L97
Really, we should autogenerate this documentation and that map from the same source. We can do that later, but how about adding comments to both places? I guess here it would have to go before or after this string.
There was a problem hiding this comment.
@bgrant0607 Done. PTAL.
madhusudancs
force-pushed
the
kubectl-get-list-deployments-daemonsets
branch
from
95ad538 to
f9c9cf4
Compare
|
GCE e2e build/test failed for commit 95ad5380afd68abb24f2a3768573e3cc62c2ad98. |
|
GCE e2e build/test failed for commit f9c9cf430ef38b69f8654b98ac8f0eea135809f7. |
|
LGTM |
bgrant0607
added
lgtm
|
Regenerate docs. |
|
Reapply lgtm after you do that. |
madhusudancs
force-pushed
the
kubectl-get-list-deployments-daemonsets
branch
from
f9c9cf4 to
e7f4d3a
Compare
|
PR changed after LGTM, removing LGTM. |
k8s-github-robot
removed
the
lgtm
|
@bgrant0607 ran update scripts and it generated nothing. Tried it again now, nothing. Just pushed the rebased commit. Reapplying the label. |
madhusudancs
added
the
lgtm
|
Thanks @madhusudancs. Maybe something else was wrong. |
|
GCE e2e test build/test passed for commit e7f4d3ac9bec5b0c48249b05e037876b267bd03d. |
|
@bgrant0607 yeah. @k8s-bot test this issue: #IGNORE |
|
GCE e2e test build/test passed for commit e7f4d3ac9bec5b0c48249b05e037876b267bd03d. |
|
"dep" can also be "dependency" but I cannot think of a better abbreviation |
|
How about "dp"? |
|
Let's not abbreviate right now - just add deployments, and we can On Fri, Feb 19, 2016 at 4:35 AM, Liang Mingqiang notifications@github.com
|
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e build/test failed for commit e7f4d3ac9bec5b0c48249b05e037876b267bd03d. |
bgrant0607
removed
the
lgtm
|
Ok, I'm fine with that. @madhusudancs please remove the abbreviation for deployments. Sorry. |
|
Given the length of the term "deployment," and the fact that we're going to be moving everything over to deployments on 1.2 and will be doing a lot of work with them with kubectl, I know it would be extremely helpful to us to add an abbreviation (I vote for dp). Just my $.02. |
|
Nothing really prevents us from adding an abbreviation in 1.2.1 or
something. I would just like to spend more time discussing and making
sure we like a particular abbrev. We're already making a flurry of
changes at the end, would like to get those settled first.
|
|
I agree with @smarterclayton on this one. Just improving the help output to show deployments and daemonset as a valid object makes my life easier and will do the same for users. Regarding the abbreviation I think we will do a better job if we look at the current set and try to make things consistent. |
madhusudancs
force-pushed
the
kubectl-get-list-deployments-daemonsets
branch
from
e7f4d3a to
781480d
Compare
|
@bgrant0607 @smarterclayton Removed the abbreviation for deployments. PTAL. |
|
GCE e2e test build/test passed for commit 781480d. |
|
LGTM |
bgrant0607
added
lgtm
|
Merging. |
…nts-daemonsets Add DaemonSets and Deployments to valid resources list in kubectl.
@bgrant0607 Should there be a short form for Deployments? I thought about 'dep', but that sounds more like dependencies.