Make DNS working on docker and docker-multinode #21504
Conversation
luxas
force-pushed
the
fix_certs_for_hyperkube
branch
from
33ab1a5 to
7e48c9e
Compare
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e test build/test passed for commit 7e48c9eef51feba8ec4d9c8bb3dc56bcdbda0893. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
|
||
| $ kubectl -s "$KUBE_SERVER:8080" --namespace=kube-system create -f ./skydns-svc.yaml | ||
| $ kubectl --namespace=kube-system create -f ./skydns.yaml |
There was a problem hiding this comment.
Why is it that you don't need to set -s flag?
There was a problem hiding this comment.
The default is -s flag is http://localhost:8080, and that's were apiserver will listen by default for docker-multinode (when running from the same node)
Anyway, it's overkill to specify a separate server option here (the user have to be able to kubectl get po for example)
One may use the -s flag if running kubectl from another node, or export KUBERNETES_MASTER for example. But the user should know that
|
The hypercube install of 1.2.0-alpha8 does not automatically create the kube-system name space (rather it has only "default"). SkyDNS should probably use default or indicate that manually creating the namespace "kubectl create namespace kube-system" will be needed to avoid getting "Error from server: error when creating "./skydns.yaml": namespaces "kube-system" not found" |
|
@luxas @fgrzadkowski It would be great if we can get this merged before the next alpha or beta build. Is there anything I can help with? |
|
@jumpkick I will probably include the creation of @gopinatht As soon as #21379 is merged (soon) I'll rebase and this may be LGTM'd, so it will probably be included in the next release. |
|
Thanks for reviewing, Filip. |
k8s-github-robot
added
the
needs-rebase
|
PR needs rebase |
luxas
force-pushed
the
fix_certs_for_hyperkube
branch
from
7e48c9e to
cd80bf8
Compare
…file. Make DNS working on docker and docker-multinode
k8s-github-robot
removed
the
needs-rebase
luxas
force-pushed
the
fix_certs_for_hyperkube
branch
from
cd80bf8 to
e9af6c3
Compare
|
@fgrzadkowski @thockin I copied https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/skydns-rc.yaml.in, bumped to Now the two |
|
GCE e2e build/test failed for commit e9af6c3. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
|
GCE e2e build/test failed for commit cd80bf8d659c618c4e5ee54edc04fa38d39865d8. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
fgrzadkowski
added
lgtm
|
@k8s-bot test this; issue #IGNORE |
|
GCE e2e build/test passed for commit e9af6c3. |
fgrzadkowski
added
the
priority/important-soon
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Update the DNS template from
cluster/addons/dnsand combine into one file.Fixes: #19228 #18227
Related to: #21379 #21357
@fgrzadkowski