Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rolling-update --image nil pointer dereference #21445

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Fix rolling-update --image nil pointer dereference #21445

merged 1 commit into from
Feb 24, 2016
+1 −2

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo added kind/bug Categorizes issue or PR as related to a bug. team/ux labels Feb 18, 2016
@caesarxuchao
Copy link
Member

Could you check if this is the only place that tried to access the codecs via registered? Could you remove the Codec from GroupMeta struct to prevent future misuse: https://github.com/kubernetes/kubernetes/blame/master/pkg/apimachinery/types.go#L37? Thanks.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2016
@janetkuo
Copy link
Member Author

@caesarxuchao both done

@caesarxuchao
Copy link
Member

Thanks! LGTM.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2016
@bgrant0607 bgrant0607 added this to the v1.2 milestone Feb 18, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit 69ef30ae947bef5e7e99c611e7ccb50ee675afed.

@janetkuo
Copy link
Member Author

@k8s-bot unit test this issue: #IGNORE (test didn't start)

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit b341df42aa54338cc14741330543fad00118d380.

@caesarxuchao
Copy link
Member 

# k8s.io/kubernetes/examples/apiserver
/go/src/k8s.io/kubernetes/examples/apiserver/apiserver.go:40: groupMeta.Codec undefined (type *apimachinery.GroupMeta has no field or method Codec)

Someone else is still accessing the codec through groupMeta. We need to remove that line as well.

@bgrant0607 bgrant0607 added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 23, 2016
@janetkuo
Copy link
Member Author

@caesarxuchao I'll remove the Codec from GroupMeta struct in a follow-up PR since the test is broken by it and the fix (the first commit) is more urgent.

@janetkuo janetkuo force-pushed the fix-rolling-update-nil branch from b341df4 to e735667 Compare February 23, 2016 23:08
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2016
@janetkuo
Copy link
Member Author

Re-applying LGTM since the first commit is LGTMed.

@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

GCE e2e test build/test passed for commit e735667.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@janetkuo janetkuo mentioned this pull request Feb 24, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit e735667.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit e735667.

@janetkuo
Copy link
Member Author

@k8s-bot unit test this issue: #21451

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e build/test failed for commit e735667.

@bgrant0607
Copy link
Member

Update demo failed.

@janetkuo
Copy link
Member Author

The update demo failure looks like an unrelated flake.

    Unable to connect to the server: dial tcp 104.154.42.133:443: i/o timeout

@caesarxuchao
Copy link
Member

There is another e2e flake:

Feb 23 20:32:24.129: INFO: Unexpected error occurred: gave up waiting for pod 'pod-e680e7ef-daae-11e5-af9d-42010af00007' to be 'success or failure' after 5m0s
[AfterEach] EmptyDir volumes
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework.go:84
STEP: Collecting events from namespace "e2e-tests-emptydir-sc845".
Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {default-scheduler } Scheduled: Successfully assigned pod-e680e7ef-daae-11e5-af9d-42010af00007 to e2e-gce-master-1-minion-eecp
Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {kubelet e2e-gce-master-1-minion-eecp} Pulling: pulling image "gcr.io/google_containers/mounttest-user:0.3"
Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {kubelet e2e-gce-master-1-minion-eecp} Failed: Failed to pull image "gcr.io/google_containers/mounttest-user:0.3": Error pulling image (0.3) from gcr.io/google_containers/mounttest-user, Get https://gcr.io/v1/images/3f2f373c89b743b1c46b1b593d1b152e85e6d2f77c7e45bc6247669218a0de4a/ancestry: dial tcp 173.194.69.82:443: i/o timeout
Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {kubelet e2e-gce-master-1-minion-eecp} FailedSync: Error syncing pod, skipping: failed to "StartContainer" for "test-container" with ErrImagePull: "Error pulling image (0.3) from gcr.io/google_containers/mounttest-user, Get https://gcr.io/v1/images/3f2f373c89b743b1c46b1b593d1b152e85e6d2f77c7e45bc6247669218a0de4a/ancestry: dial tcp 173.194.69.82:443: i/o timeout"

Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {kubelet e2e-gce-master-1-minion-eecp} BackOff: Back-off pulling image "gcr.io/google_containers/mounttest-user:0.3"
Feb 23 20:32:24.143: INFO: event for pod-e680e7ef-daae-11e5-af9d-42010af00007: {kubelet e2e-gce-master-1-minion-eecp} FailedSync: Error syncing pod, skipping: failed to "StartContainer" for "test-container" with ImagePullBackOff: "Back-off pulling image \"gcr.io/google_containers/mounttest-user:0.3\""

looks like #21029

@k8s-github-robot
Copy link

@caesarxuchao
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit e735667.

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2016
@bgrant0607
Copy link
Member

Merging.

bgrant0607 added a commit that referenced this pull request Feb 24, 2016
@bgrant0607
Merge pull request #21445 from janetkuo/fix-rolling-update-nil
4add4eb 
Fix rolling-update --image nil pointer dereference
@bgrant0607 bgrant0607 merged commit 4add4eb into kubernetes:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
area/kubectl kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@janetkuo @caesarxuchao @k8s-github-robot @k8s-bot @bgrant0607 @k8s-teamcity-mesosphere @googlebot