Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate fake clientset for release_1_2 #21348

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Generate fake clientset for release_1_2 #21348

merged 1 commit into from
Feb 19, 2016

Conversation

caesarxuchao
Copy link
Member

  1. move the ClientGenArgs struct to a separate package so both generator-for-clientset.go and generator_fake_for_clientset.go can use it.
  2. move the generated fake clientset to pkg/client/clientset_generated//fake
  3. generate the fakes for release_1_2 clientset for the first time.

TODO: move the discovery client and the fake discovery client to a separate package.

cc @lavalamp

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 16, 2016
@caesarxuchao caesarxuchao self-assigned this Feb 16, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 16, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 16, 2016

GCE e2e build/test failed for commit e39a8c67f90ab59740141e57724a200801af5759.

@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e test build/test passed for commit 53b7b20473fdde7662fb2e73b613589611577f8d.

@caesarxuchao caesarxuchao assigned krousey and unassigned caesarxuchao Feb 17, 2016
@caesarxuchao caesarxuchao changed the title [WIP] Generate fake clientset for release_1_2 Generate fake clientset for release_1_2 Feb 17, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e build/test failed for commit 67e1ed2fc4712c1b040e79a6f5b56a843cec427d.

@krousey
Copy link
Contributor

krousey commented Feb 17, 2016

@k8s-bot ok to test

@krousey
Copy link
Contributor

krousey commented Feb 17, 2016

This LGTM. Squash and apply label.

@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e test build/test passed for commit 67e1ed2fc4712c1b040e79a6f5b56a843cec427d.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2016
@caesarxuchao
Copy link
Member Author

Squashed. Applying the label per previous comment. Thanks @krousey.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit ad46715.

@caesarxuchao
Copy link
Member Author

@k8s-oncall, travis is really slow (2+ hours), anyway to bypass it?

@pwittrock
Copy link
Member

as long as e2e and unit/integration pass you shouldn't need travis for the sq

@caesarxuchao
Copy link
Member Author

@pwittrock thanks for the info.

@caesarxuchao
Copy link
Member Author

No production code uses the versioned client yet, adding the e2e-not-required label.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 19, 2016
Merge pull request #21348 from caesarxuchao/generate-fake-for-1-2
eb45154 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit eb45154 into kubernetes:master Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krousey krousey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@caesarxuchao @k8s-github-robot @k8s-bot @krousey @pwittrock @k8s-teamcity-mesosphere @googlebot