Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mysql-galena example's config files #21345

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

ckleban
Copy link
Contributor

@ckleban ckleban commented Feb 16, 2016

I recently ran the mysql-galena example on a newly minted v1.1.7 kubernetes cluster and there seems to be errors in the configuration that prevent the example from working. Perhaps these configuration examples were created on an older kubernetes version and now they no longer work?

Anyhow, I've made some minor changes which allow the example to launch and function correctly.

@k8s-bot
Copy link

k8s-bot commented Feb 16, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Feb 16, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Feb 17, 2016
@thockin
Copy link
Member

thockin commented Feb 17, 2016

ok to test

@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e build/test failed for commit c8a2ee3.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 17, 2016
@k8s-github-robot k8s-github-robot merged commit 6d50c22 into kubernetes:master Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants