Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make endpoints return 400 instead of 500 #2124

Merged
merged 1 commit into from
Nov 3, 2014
Merged

Make endpoints return 400 instead of 500 #2124

merged 1 commit into from
Nov 3, 2014
+41 −3

Conversation

brendandburns
Copy link
Contributor

smarterclayton
smarterclayton reviewed Nov 2, 2014
View reviewed changes
pkg/api/errors/errors.go
@@ -116,6 +116,21 @@ func NewInvalid(kind, name string, errs ValidationErrorList) error {
}}
}

func NewBadRequest(reason string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@brendandburns
Copy link
Contributor Author

comments addressed, ptal.

Thanks!
--brendan

@dchen1107
Copy link
Member

LGTM

dchen1107 added a commit that referenced this pull request Nov 3, 2014
@dchen1107
Merge pull request #2124 from brendandburns/fix
81785d8 
Make endpoints return 400 instead of 500
@dchen1107 dchen1107 merged commit 81785d8 into kubernetes:master Nov 3, 2014
@erictune erictune mentioned this pull request Nov 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

status code should be 400, was 500, for DELETE /endpoints
3 participants
@brendandburns @dchen1107 @smarterclayton