docs/rkt: Document the different UX. #21221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-gu
added
kind/documentation
yifan-gu
changed the title
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
GCE e2e test build/test passed for commit da8415c22e43abb41b4a7c698e98e88a75768274. |
|
GCE e2e test build/test passed for commit 2e7a9691455af5451c4f85964c2c0eec9e10a014. |
|
GCE e2e test build/test passed for commit aa011372b812425197b10dbbfcee04d4fabb71bc. |
|
|
||
| ### Doesn't support ENTRYPOINT + CMD feature | ||
|
|
||
| To run a Docker image, rkt will transfer it into App Container Image (ACI) format first. |
|
@yujuhong Addressed comments, ptla, thanks :) |
|
GCE e2e test build/test passed for commit 50fe8dce26e72acee321ba733941edc4dd1d633e. |
| - 1000 | ||
| ``` | ||
|
|
||
| All the three examples above are valid as they contains the full executable path, plus the arguments. |
|
lgtm with some nits. /cc @dchen1107 |
|
@yujuhong Comments fixed. Thank you :) |
|
GCE e2e test build/test passed for commit b3ed1b6. |
yujuhong
added
the
lgtm
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 22, 2016
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for #20905 (comment)
cc @kubernetes/sig-node @jonboulle @sjpotter