Update to selector generation design #21192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
erictune
force-pushed
the
manual-selector
branch
from
68ae4fb to
b258cbc
Compare
|
CLAs look good, thanks! |
|
@bgrant0607 you okayed this name change in a chat. |
|
Labelling this PR as size/M |
k8s-github-robot
added
kind/design
Also improve doc slightly.
Avoids double negative.
erictune
force-pushed
the
manual-selector
branch
from
b258cbc to
2b9d22e
Compare
|
GCE e2e test build/test passed for commit b258cbc4bafa62e336a3ffc8cc39c368e83d10c3. |
|
GCE e2e test build/test passed for commit 2b9d22e. |
bgrant0607
added
lgtm
|
LGTM |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 13, 2016
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from proposals to design because it is going to happen.
Renamed from "noAutoSelector" to "manualSelector" to avoid a double negative.
Defaulting and meaning is the same.