Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Change master to m3.medium by default #21160

Merged
merged 1 commit into from
Feb 20, 2016

Conversation

justinsb
Copy link
Member

m3.large for > 150 nodes.

t2.micro often runs out of memory. The t2 class has very
difficult-to-understand behaviour when it runs out of CPU. The
m3.medium is reasonably affordable, and avoids these problems.

WIP because docs

Fix #21151

Issue #18975

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 12, 2016

GCE e2e test build/test passed for commit 129c4243ce7398f840bc5dcda1c194162bf0f4a4.

@justinsb justinsb added this to the v1.2-candidate milestone Feb 16, 2016
@brendandburns
Copy link
Contributor

@justinsb LGTM, modulo docs. Can you add the doc update to this PR?

m3.large for > 150 nodes.

t2.micro often runs out of memory.  The t2 class has very
difficult-to-understand behaviour when it runs out of CPU.  The
m3.medium is reasonably affordable, and avoids these problems.

Fix kubernetes#21151

Issue kubernetes#18975
@justinsb justinsb changed the title WIP: AWS: Change master to m3.medium by default AWS: Change master to m3.medium by default Feb 17, 2016
@justinsb
Copy link
Member Author

Added docs.... possibly too many words, but there's just so much to say :-) .

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e test build/test passed for commit a16372c.

@justinsb
Copy link
Member Author

We have had some reports that using a t2 is actually OK - that we had a bug that was the root of the problems here (e.g. #18975 (comment)). I still think we are better to recommend a configuration with more breathing room, and let people that want to save money knowingly & deliberately opt-in to the smaller configuration. @brendandburns ?

@justinsb justinsb modified the milestones: v1.2, v1.2-candidate Feb 18, 2016
@justinsb
Copy link
Member Author

Moving to v1.2 so we make a decision either way...

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed area/platform/aws labels Feb 19, 2016
@brendandburns
Copy link
Contributor

@justinsb sgtm. lgtm.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e build/test failed for commit a16372c.

@justinsb
Copy link
Member Author

Is it OK to mark this e2e-not-required? Feels a bit like cheating, but it might at least free up some e2e bandwidth, and it isn't like e2e is testing this...

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 20, 2016
@k8s-github-robot k8s-github-robot merged commit 6c5bf89 into kubernetes:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants