Provide current namespace to InClusterConfig #21095
Conversation
k8s-github-robot
added
kind/api-change
liggitt
force-pushed
the
sa-namespace
branch
from
b85bf6d to
5badb57
Compare
k8s-github-robot
added
size/M
liggitt
force-pushed
the
sa-namespace
branch
2 times, most recently
from
c184ce0 to
3d079b2
Compare
|
Labelling this PR as size/L |
k8s-github-robot
added
size/L
| // TODO: generic way to figure out what namespace you are running in? | ||
| // This way assumes you've set the POD_NAMESPACE environment variable | ||
| // using the downward API. | ||
| // This way assumes you've set the POD_NAMESPACE environment variable using the downward API. |
There was a problem hiding this comment.
Note that this is required for backwards compatibility with old clients
There was a problem hiding this comment.
This should have been prefixed with KUBERNETES_, KUBE_, or somesuch. :-(
Lots of examples use this, but I don't see it actually documented somewhere.
|
One question on the tests, then needs @kubernetes/kube-api review (since it adds the constant that is part of the secret, and the secret schema is public API), then LGTM |
liggitt
force-pushed
the
sa-namespace
branch
from
3d079b2 to
f3a4be2
Compare
liggitt
force-pushed
the
sa-namespace
branch
from
f3a4be2 to
20216fa
Compare
|
LGTM pending @bgrant0607's review |
|
GCE e2e test build/test passed for commit 20216fa. |
| @@ -375,6 +378,10 @@ func (e *TokensController) generateTokenIfNeeded(serviceAccount *api.ServiceAcco | |||
| if needsCA { | |||
| secret.Data[api.ServiceAccountRootCAKey] = e.rootCA | |||
| } | |||
| // Set the namespace | |||
| if needsNamespace { | |||
| secret.Data[api.ServiceAccountNamespaceKey] = []byte(secret.Namespace) | |||
There was a problem hiding this comment.
@pmorie Note that service account secrets are automatically updated.
|
LGTM, but we should document this. |
bgrant0607
added
the
lgtm
liggitt
added
the
release-note
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 20216fa. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 20216fa. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 20216fa. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 20216fa. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 20216fa. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
|
We need to be sure and build a new kubectl container for 1.2 (for use as a side-car in pods). I think we should be doing that anyway as part of the release. |
I would hope so, if only to get new kubectl features |
Fixes #21073