Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-cmd.sh can fail if public IP not available #2109

Merged
merged 1 commit into from
Nov 3, 2014
Merged

test-cmd.sh can fail if public IP not available #2109

merged 1 commit into from
Nov 3, 2014

Conversation

smarterclayton
Copy link
Contributor

test-cmd runs a 127.0.0.1 version of the apiservers, but does not
set --public_address_override, which means it can fail on some systems
(like Macs) which don't expose a bindable external port by default.

Since reachability is not necessary for test-cmd.sh today, set
public_address_override to 127.0.0.1

@smarterclayton
test-cmd.sh can fail if public IP not available
6e1527e 
test-cmd runs a 127.0.0.1 version of the apiservers, but does not
set --public_address_override, which means it can fail on some systems
(like Macs) which don't expose a bindable external port by default.

Since reachability is not necessary for test-cmd.sh today, set
public_address_override to 127.0.0.1
@smarterclayton smarterclayton added area/test kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 1, 2014
@smarterclayton
Copy link
Contributor Author 

I1101 18:35:49.773094 33526 master.go:166] '::1' (::1/128) is a loopback address, ignoring.
I1101 18:35:49.773108 33526 master.go:166] '127.0.0.1' (127.0.0.1/8) is a loopback address, ignoring.
I1101 18:35:49.773126 33526 master.go:171] Will report fe80::1 as public IP address.
F1101 18:35:49.773944 33526 apiserver.go:188] listen tcp [fe80::1]:7080: bind: can't assign requested address

For further debugging

@markturansky markturansky mentioned this pull request Nov 3, 2014
Merged
@markturansky
Copy link
Contributor

This fix is required by #2086

@markturansky
Copy link
Contributor

LGTM. Works for me.

@smarterclayton
Copy link
Contributor Author

Merging because this breaks travis unit tests on some instances.

smarterclayton added a commit that referenced this pull request Nov 3, 2014
@smarterclayton
Merge pull request #2109 from smarterclayton/test_cmd_can_fail_on_pub…
3836d24 
…lic_addr

test-cmd.sh can fail if public IP not available
@smarterclayton smarterclayton merged commit 3836d24 into kubernetes:master Nov 3, 2014
@smarterclayton smarterclayton deleted the test_cmd_can_fail_on_public_addr branch February 11, 2015 02:21
@mqliang mqliang mentioned this pull request Feb 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/test kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarterclayton @markturansky