Labelling this PR as size/L

GCE e2e build/test failed for commit 27c77c85f4ff82e4ae5b6fd0b5966ca2b741fafc.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@mqliang Most users are going to be using ReplicationController for a while, so we can't remove the RC-based functionality from the scheduler yet. We should add ReplicaSet, but keep ReplicationController.

cc @janetkuo @Kargakis

+1 to @bgrant0607 's comment. Thanks for noticing this, @mqliang .

I think I got it: We can replace ReplicationController to ReplicaSet in DeploymentController because k8s v1.0 has no DeploymentController. But for selector_spreading functionality in scheduler, we must make it back compatible with v1.0. Hence, we should _ADD_ ReplicaSet, and keep ReplicationController.

GCE e2e build/test failed for commit 93b96758d087426dcab0170bd1f3e0697c9bbf48.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e build/test failed for commit 15f9591f3399c8f0f89337ed78945362879dcca1.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Instead of creating a new LabelSelectorSpread type and associated CalculateSpreadPriority(), it would be better to combine these into the existing SelectorSpread and its CalculateSpreadPriority(). So you would have

type SelectorSpread struct {
    podLister        algorithm.PodLister
    serviceLister    algorithm.ServiceLister
    controllerLister algorithm.ControllerLister
    replicaSetLister algorithm.ReplicaSetLister
}

and in SelectorSpread.CalculateSpreadPriority() you would do

    services, err := s.serviceLister.GetPodServices(pod)
    if err == nil {
        for _, service := range services {
            selectors = append(selectors, labels.SelectorFromSet(service.Spec.Selector))
        }
    }
    controllers, err := s.controllerLister.GetPodControllers(pod)
    if err == nil {
        for _, controller := range controllers {
            selectors = append(selectors, labels.SelectorFromSet(controller.Spec.Selector))
        }
    }
    rss, err := s.replicaSetLister.GetPodReplicaSets(pod)
    if err == nil {
        for _, rs := range rss {
            if selector, err := unversioned.LabelSelectorAsSelector(rs.Spec.Selector); err == nil {
                selectors = append(selectors, selector)
            }
        }
    }

Once you have created the selectors list, there's really no difference between how you handle services, ReplicationControllers, or ReplicaSets. So I don't think there's any need to add a new LabelSelectorSpreadPriority priority function. You can just add ReplicaSet to existing SelectorSpread.

Does that sound reasonable?

GCE e2e build/test failed for commit cbde1f3fdb142c74a7def7f9192bab99d5e018ab.

• Build Log
• Test Artifacts
• Internal Jenkins Results

ping @mqliang -- I'd really like to get this into 1.2

GCE e2e build/test failed for commit d7269ab44a6b578b4651b79e6bf1e9e8a2772e3d.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e test build/test passed for commit c888649882c075f81ca4778a694841c634c6b987.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@davidopp Updated. PTAL.

This looks great -- thanks! I just had one very minor comment.

GCE e2e test build/test passed for commit fbf859c09d0614320674352e3baae3b7eb6c8da4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@davidopp Comments addressed. PTAL

LGTM

Thanks!

GCE e2e test build/test passed for commit 0aab44a.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e test build/test passed for commit 0aab44a.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue