Stop httptest server. #2090
Merged
Stop httptest server. #2090
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It's too bad that we can't make this some sort of atexit style thing instead of adding it to every test. |
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
KEP: efficient node heartbeats
ffromani
pushed a commit
to ffromani/kubernetes
that referenced
this pull request
Oct 29, 2024
OCPBUGS-42168: Bump k8s api to 1.29.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2018 With a special case of pkg/apiserver/watch_test.go, where CloseClientConnection is used to close client connections (keep alive is used).