Godeps: Bump rkt api, go grpc, go protobuf. #20831
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
ok to test |
|
GCE e2e test build/test passed for commit ead87d4. |
| }, | ||
| { | ||
| "ImportPath": "github.com/coreos/etcd/discovery", | ||
| "Comment": "v2.2.2-4-ge0c7768", | ||
| "Rev": "e0c7768f94cdc268b2fce31ada1dea823f11f505" | ||
| "Comment": "v2.2.5", |
There was a problem hiding this comment.
nit: I wish "github.com/coreos/etcd/client" was self-sufficient without needing a lot of other packages.
|
Can you fix the commit? It appears as though someone else made it. |
|
@jonboulle is not the original author (@yifan-gu is). I'm not aware of any method to manually override the cla bot without consent from the commit author, @lavalamp, maybe you know? |
|
OK. Yeah, if @yifan-gu could ack this (just say something here) that'd be great. |
|
ack |
|
LGTM |
|
cc @wojtek-t @gmarek w.r.t. scalability. we are bumping the etcd client version here. ping @googlebot |
mikedanese
added
the
lgtm
|
LGTM |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@mikedanese - OK, we'll monitor test results. |
|
anything we need to do here to kick the cla/google check? |
|
There's a human-approved label, so don't worry about it. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit ead87d4. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Supersedes #19931 - this is that PR rebased and with Godeps licenses fixed.