-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix another instance of golang #12262 #20752
Conversation
Labelling this PR as size/XS |
GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71. |
Thanks! |
@k8s-bot ok to test |
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71. |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71. |
@brendandburns seem OK to merge given it passes the tests? |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test failed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71. |
e2e test flake is #21045 |
Reliably reproducible on two up-to-date Fedora 23 machines using go 1.5.3, both one Core i7-4770R and a Core i7-4790. golang/go#12262
93dec63
to
905dfd9
Compare
rebased and repushed to get fix for #21045 |
PR changed after LGTM, removing LGTM. |
GCE e2e test build/test passed for commit 905dfd9. |
@brendandburns another LGTM if you could... no changes, just a rebase to pick up the flake fix. Thanks! |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit 905dfd9. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Reliably reproducible on two up-to-date Fedora 23 machines using
go 1.5.3, both one Core i7-4770R and a Core i7-4790.
golang/go#12262
TestOIDCAuthentication times out because the server has a couple pending open connections.