Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another instance of golang #12262 #20752

Merged
merged 1 commit into from
Feb 13, 2016

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Feb 5, 2016

Reliably reproducible on two up-to-date Fedora 23 machines using
go 1.5.3, both one Core i7-4770R and a Core i7-4790.

golang/go#12262

TestOIDCAuthentication times out because the server has a couple pending open connections.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 5, 2016

GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2016
@brendandburns
Copy link
Contributor

Thanks!

@brendandburns
Copy link
Contributor

@k8s-bot ok to test

@k8s-github-robot
Copy link

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

@k8s-bot
Copy link

k8s-bot commented Feb 8, 2016

GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Feb 10, 2016

GCE e2e test build/test passed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71.

@dcbw
Copy link
Member Author

dcbw commented Feb 10, 2016

@brendandburns seem OK to merge given it passes the tests?

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 11, 2016

GCE e2e build/test failed for commit 93dec63abddb3ace9b84c3843dcfe0261cc2db71.

@dcbw
Copy link
Member Author

dcbw commented Feb 11, 2016

e2e test flake is #21045

Reliably reproducible on two up-to-date Fedora 23 machines using
go 1.5.3, both one Core i7-4770R and a Core i7-4790.

golang/go#12262
@dcbw
Copy link
Member Author

dcbw commented Feb 12, 2016

rebased and repushed to get fix for #21045

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 12, 2016

GCE e2e test build/test passed for commit 905dfd9.

@dcbw
Copy link
Member Author

dcbw commented Feb 12, 2016

@brendandburns another LGTM if you could... no changes, just a rebase to pick up the flake fix. Thanks!

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 13, 2016

GCE e2e test build/test passed for commit 905dfd9.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 13, 2016
@k8s-github-robot k8s-github-robot merged commit a2ce07e into kubernetes:master Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants