Openstack provider #2051
Openstack provider #2051
Conversation
anguslees
force-pushed
the
openstack-provider
branch
from
b943e67 to
79b6c8e
Compare
|
Have you completed the CLA? https://github.com/GoogleCloudPlatform/kubernetes/blob/master/CONTRIBUTING.md |
|
Yes, I've written these patches on Rackspace company time, and (I've been told) Rackspace has signed the Google corp CLA. |
|
Lots of small things. Basically LGTM. Thanks for making the godep update a separate commit. |
anguslees
force-pushed
the
openstack-provider
branch
4 times, most recently
from
af9544b to
7582985
Compare
|
ping @brendandburns? I think I might have confused you by uploading an entire new patch rather than incrementals. My apologies, I'm suffering workflow clash between gerrit and github :-/ |
|
@anguslees Brendan is out speaking today. He can probably get to this tonight or tomorrow. Regardless, doing a rebase would help to merge it cleanly. Let me know if you need help getting that done as a good github workflow does take a little bit of time to figure out. |
|
yeah, can you rebase this, and then I think we can submit... |
|
Can one of the admins verify this patch? |
anguslees
force-pushed
the
openstack-provider
branch
2 times, most recently
from
6d0bc11 to
b92e52f
Compare
Also add a trivial implementation of Zones() too. This only supports a single region/zone currently (the region where kubernetes is running).
Turned out to be invaluable while debugging issues - I expect it will be for others too. Conflicts: pkg/cloudprovider/openstack/openstack.go
anguslees
force-pushed
the
openstack-provider
branch
from
b92e52f to
a00f73c
Compare
|
ping @brendandburns - is this blocking on me? |
|
@anguslees Thanks for the rebase. Sorry, github doesn't ping PRs when they are updated, only when there are messages added. Merging. |
gophercloud v1.0 was released. More powerful, but quite different API, unfortunately.
Now with added TCPLoadBalancer support.