Make client.Request/RESTClient more testable and fakeable #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves polling to a function provided by the RESTClient, not innate to Request. Moves doRequest from RESTClient to Request for clarity.
smarterclayton
force-pushed
the
make_request_testable
branch
from
c4b67ed to
c1138cc
Compare
| @@ -603,6 +603,7 @@ type Status struct { | |||
| type StatusDetails struct { | |||
| // The ID attribute of the resource associated with the status StatusReason | |||
| // (when there is a single ID which can be described). | |||
| // TODO: replace with Name | |||
|
LGTM, nit fixes optional. |
smarterclayton
force-pushed
the
make_request_testable
branch
from
c1138cc to
71fecef
Compare
|
Nits addressed and tests are green |
smarterclayton
added a commit
that referenced
this pull request
Oct 29, 2014
Make client.Request/RESTClient more testable and fakeable
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Aug 20, 2024
NO-JIRA: update downstream owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow kubectl to be more thoroughly tested in #2000