Labelling this PR as size/S

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

When was docker daemon introduced? We need to ensure compatability...

https://blog.docker.com/2015/08/docker-1-8-content-trust-toolbox-registry-orchestration/
docker daemon is introduced in docker 1.8.

/cc @dchen1107

@aanm Thanks for the pr. @Random-Liu and I talked about this yesterday on removing -d option, including our containervm image too.

Compatibility check: docker daemon was fully introduced for docker 1.8, but it is compatible with docker 1.7 release which we haven't dropped the support yet.

LGTM

@derekwaynecarr

@dchen1107 ah cool thanks for checking that out

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

My above compatibility check is wrong. There is a copy&paste error when I tested it: instead of passing "daemon", I passed "--daemon" as startup options for my docker daemon.

Just verify it again, it is not compatible with docker 1.7 release. In this case, we have to detect docker version and pass different option based on the version.

GCE e2e test build/test passed for commit c6ec72d503f760d3a8ddc8c652e6b8dc1cc15f6b.

• Build Log
• Test Artifacts
• Internal Jenkins Results

The bash ones were easy. The cluster/saltbase/salt/docker/docker.service is more tricky. Any suggestions?

Labelling this PR as size/M

GCE e2e test build/test passed for commit 9268bb2c0200e0bcd786c202ea7b8fc6f94cc229.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e test build/test passed for commit f87f1f02af3fcd20d141d0c38482dd4d7d2253c0.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e test build/test passed for commit b099bf9089faec73a187f54f98b68689eaf7d399.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@aanm

docker \
    -d 

is unfortunately fully possible. E.g. in docker-multinode scripts.

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@dchen1107 docker was released today

@aanm Please fix the failure tests. Otherwise lgtm

GCE e2e test build/test passed for commit 97acdf4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

Please note the cluster/saltbase/salt/docker/docker.service is not detecting the different versions of docker so it will fail with versions lower than 1.8.0.

How is it with Kubernetes docker compability? I think I've heard somewhere that Kubernetes should support three docker versions back. So for v1.2 that would mean: 1.10.0, 1.9.1, 1.8.3, if I understand it correctly.

But I don't know for sure... See #13742

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

Fixes #20980

LGTM

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

GCE e2e build/test failed for commit 97acdf4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot e2e test this please github issue: #22088

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

GCE e2e build/test passed for commit 97acdf4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e build/test passed for commit 97acdf4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot unit test this please github issue: #22128

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 97acdf4.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue