Demo files for logging for Fluentd and GCP #2021
Merged
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Happy to merge whenever you think its ready. I'm not sure if you want to wait for everything and do it all at once, or you are happy to merge it piecemeal. |
|
I'm in favour of merging early and iterating. S On Wed, Oct 29, 2014 at 8:47 PM, Brendan Burns notifications@github.com
|
satnam6502
force-pushed
the
fluentd-gcp
branch
2 times, most recently
from
59f636b to
56f400d
Compare
satnam6502
force-pushed
the
fluentd-gcp
branch
from
56f400d to
260b7ea
Compare
|
I've added a comment at the top of the synthetic and marked all the make rule as PHONY. |
|
LGTM. merging. |
brendandburns
added a commit
that referenced
this pull request
Oct 31, 2014
Demo files for logging for Fluentd and GCP
ffromani
pushed a commit
to ffromani/kubernetes
that referenced
this pull request
Sep 19, 2024
OCPBUGS-36773: UPSTREAM: <carry>: Disable vSphere tests with pre-provisioned volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I am proposing just to check in the demo files a user needs to quick off a synthetic logger on the assumption that the Fluentd + GCP configured on the cluster will collect without any further setup.