-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a knob to enable quorum read #20145
Conversation
Labelling this PR as size/M |
GCE e2e build/test failed for commit 947fb15ec48ad08bdb6410914faea3874b9ea326. |
GCE e2e build/test failed for commit 07c52d219995db0875b7f04dc8b57b5c65df1e33. |
GCE e2e test build/test passed for commit edca315c9657c755c2bd434aff0e87fef9013b9a. |
GCE e2e test build/test passed for commit ba7a56184fe4233081435dedd4eebac502a72995. |
GCE e2e test build/test passed for commit 4b8888efb128fcf50d695e1db61f26a0463e05ec. |
GCE e2e test build/test passed for commit 4b8888efb128fcf50d695e1db61f26a0463e05ec. |
GCE e2e test build/test passed for commit 941c92cb6baafc3f0c41cd31552c6bc930870456. |
GCE e2e test build/test passed for commit a6f7ea99c9ab01127f8262c4d8975f77fd9a9f0e. |
GCE e2e test build/test passed for commit e586b7cfad9f39919adc0b41f8a453c5bd0bc73c. |
GCE e2e test build/test passed for commit d5f6c1191414fbe3e9f2a3fd649c2e5ffd286801. |
This looks fine for the most part. @nikhiljindal is this the right place to inject the quorum option in the API server config? |
GCE e2e test build/test passed for commit d7a5e360c07dce06bbf211de4483a02a26312fda. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
This seems like a generic knob which will be useful for all apiservers. |
@nikhiljindal Reworked. PTAL |
GCE e2e test build/test passed for commit b0e06c1. |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e test build/test passed for commit b0e06c1. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit b0e06c1. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
@mqliang - thanks for this change! |
ref #19902