Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a knob to enable quorum read #20145

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

mqliang
Copy link
Contributor

@mqliang mqliang commented Jan 26, 2016

ref #19902

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 26, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e build/test failed for commit 947fb15ec48ad08bdb6410914faea3874b9ea326.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e build/test failed for commit 07c52d219995db0875b7f04dc8b57b5c65df1e33.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit edca315c9657c755c2bd434aff0e87fef9013b9a.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit ba7a56184fe4233081435dedd4eebac502a72995.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit 4b8888efb128fcf50d695e1db61f26a0463e05ec.

@k8s-bot
Copy link

k8s-bot commented Jan 27, 2016

GCE e2e test build/test passed for commit 4b8888efb128fcf50d695e1db61f26a0463e05ec.

@k8s-bot
Copy link

k8s-bot commented Jan 27, 2016

GCE e2e test build/test passed for commit 941c92cb6baafc3f0c41cd31552c6bc930870456.

@k8s-bot
Copy link

k8s-bot commented Jan 27, 2016

GCE e2e test build/test passed for commit a6f7ea99c9ab01127f8262c4d8975f77fd9a9f0e.

@k8s-bot
Copy link

k8s-bot commented Jan 27, 2016

GCE e2e test build/test passed for commit e586b7cfad9f39919adc0b41f8a453c5bd0bc73c.

@k8s-bot
Copy link

k8s-bot commented Jan 27, 2016

GCE e2e test build/test passed for commit d5f6c1191414fbe3e9f2a3fd649c2e5ffd286801.

@krousey
Copy link
Contributor

krousey commented Jan 28, 2016

This looks fine for the most part.

@nikhiljindal is this the right place to inject the quorum option in the API server config?

@k8s-bot
Copy link

k8s-bot commented Jan 28, 2016

GCE e2e test build/test passed for commit d7a5e360c07dce06bbf211de4483a02a26312fda.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@nikhiljindal
Copy link
Contributor

This seems like a generic knob which will be useful for all apiservers.
I think we can add it to genericapiserver.ServerRunOptions instead of adding to APIServer struct in cmd/kube-apiserver/app/options/options.go

@mqliang
Copy link
Contributor Author

mqliang commented Jan 30, 2016

@nikhiljindal Reworked. PTAL

@k8s-bot
Copy link

k8s-bot commented Jan 30, 2016

GCE e2e test build/test passed for commit b0e06c1.

@krousey krousey added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge and removed needs-ok-to-merge labels Feb 1, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Feb 1, 2016

GCE e2e test build/test passed for commit b0e06c1.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 2, 2016

GCE e2e test build/test passed for commit b0e06c1.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 2, 2016
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit c5260c8 into kubernetes:master Feb 2, 2016
@mqliang mqliang deleted the quorum-read branch February 2, 2016 13:52
@wojtek-t
Copy link
Member

wojtek-t commented Feb 3, 2016

@mqliang - thanks for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants