Add `kubectl rollout status` #19946

janetkuo · 2016-01-21T21:30:54Z

Pull Request Guidelines

Please read our contributor guidelines.
See our developer guide.
Follow the instructions for labeling and writing a release note for this PR in the block below.

Implement `kubectl rollout status` that can be used to watch a deployment's rollout status

Addresses #17168; depends on #19882 (the "Add kubectl rollout" commit).
See proposal.

Fixes #25235

cc @bgrant0607 @nikhiljindal @ironcladlou @Kargakis @kubernetes/sig-config @kubernetes/kubectl @madhusudancs

This change is

janetkuo · 2016-01-21T22:19:24Z

This is blocked by #19939 since it depends on deployments watch.

ghodss · 2016-01-21T23:06:49Z

Will this command be able to be made equally useful if the deployment and its rc's do not have any of the annotations set by kubectl deploy? I ask because all our deployment object changes will be done with kubectl apply, and it would be great to still have the rollout status command be just as useful.

janetkuo · 2016-01-21T23:22:10Z

@ghodss: Based on implementation in #19581 (not merged yet), version annotations will be appended by deployment controller which updates version annotations of a deployment and its RCs when syncing the deployment.

So yes, kubectl rollout status will still be useful if the deployment object changes are done with kubectl apply.

bgrant0607 · 2016-01-22T05:04:43Z

Is this any different than kubectl get -w deployment/mydep?

If not, we could wait and add something more customized in 1.3.

janetkuo · 2016-01-22T18:20:12Z

@bgrant0607 yes, this is similar to kubectl get -w deployments. I'll add available replicas to get in another PR and we can deal with kubectl rollout status after 1.2 then.

janetkuo · 2016-01-22T18:49:40Z

PR #20009 adds availableReplicas to kubectl get deployments.

bgrant0607 · 2016-01-30T00:04:25Z

I'm going to close this to get it off my radar. It can be reopened after we decided what we want to do here.

0xmichalis · 2016-05-09T13:49:36Z

pkg/kubectl/rollout_status.go

+		return "", false, err
+	}
+	if deployment.Generation <= deployment.Status.ObservedGeneration {
+		if deployment.Status.UpdatedReplicas == deployment.Spec.Replicas {


I am going to create a helper for this in the perma-failed PR, for now, it's ok. The perma-failed PR will be merged later so I will refactor this.

janetkuo · 2016-05-10T01:46:36Z

All comments addressed. PTAL

0xmichalis · 2016-05-10T08:29:50Z

pkg/kubectl/cmd/rollout/rollout_status.go

+const (
+	status_long    = `Watch the status of current rollout, until it's done.`
+	status_example = `# Watch the rollout status of a deployment
+$ kubectl rollout status deployment/abc`


We don't use dollar signs anymore

0xmichalis · 2016-05-10T08:35:12Z

Left some comments, feel free to apply lgtm after you address them.

janetkuo · 2016-05-10T17:24:24Z

@Kargakis thanks!

0xmichalis · 2016-05-10T17:26:55Z

@janetkuo there is also https://github.com/kubernetes/kubernetes/pull/19946/files#r62630896 buried in my previous comments

janetkuo · 2016-05-10T17:40:17Z

Sorry, missed that. Add some questions in the comment.

k8s-bot · 2016-05-10T22:12:57Z

GCE e2e build/test passed for commit 67beccc.

k8s-github-robot · 2016-05-12T12:54:10Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-05-12T13:28:12Z

GCE e2e build/test passed for commit 67beccc.

k8s-github-robot · 2016-05-12T13:28:49Z

Automatic merge from submit-queue

stcheng · 2020-12-02T01:09:21Z

pkg/kubectl/rollout_status.go

+	if err != nil {
+		return "", false, err
+	}
+	if deployment.Generation <= deployment.Status.ObservedGeneration {


May I know in what condition will the observed generation be greater than the generation?

janetkuo added area/app-lifecycle area/kubectl labels Jan 21, 2016

googlebot added the cla: yes label Jan 21, 2016

janetkuo mentioned this pull request Jan 21, 2016

Develop Deployment UX equivalent to kubectl rolling-update #17168

Closed

k8s-github-robot assigned j3ffml Jan 21, 2016

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2016

janetkuo force-pushed the kubectl-rollout-status branch from 0b56fec to 289a8f8 Compare January 21, 2016 21:32

k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2016

janetkuo force-pushed the kubectl-rollout-status branch from 289a8f8 to 30d88ea Compare January 21, 2016 22:18

janetkuo changed the title ~~WIP: Add kubectl rollout status~~ RFC: Add kubectl rollout status Jan 21, 2016

bgrant0607 assigned 0xmichalis and unassigned j3ffml Jan 22, 2016

bgrant0607 closed this Jan 30, 2016

janetkuo mentioned this pull request May 5, 2016

Implement kubectl rollout status #25235

Closed

janetkuo reopened this May 5, 2016

janetkuo force-pushed the kubectl-rollout-status branch from 30d88ea to 84d63dd Compare May 6, 2016 18:51

janetkuo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2016

0xmichalis reviewed May 9, 2016
View reviewed changes

janetkuo force-pushed the kubectl-rollout-status branch from c7f1a84 to f308695 Compare May 10, 2016 01:43

0xmichalis reviewed May 10, 2016
View reviewed changes

janetkuo force-pushed the kubectl-rollout-status branch from f308695 to b57b7e6 Compare May 10, 2016 17:23

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016

janetkuo removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016

janetkuo force-pushed the kubectl-rollout-status branch from b57b7e6 to 5bb8b71 Compare May 10, 2016 20:41

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016

Add kubectl rollout status

67beccc

janetkuo force-pushed the kubectl-rollout-status branch from 052c75f to 67beccc Compare May 10, 2016 20:49

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016

0xmichalis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016

janetkuo added this to the v1.3 milestone May 11, 2016

janetkuo added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 11, 2016

k8s-github-robot merged commit 0c2641d into kubernetes:master May 12, 2016

janetkuo mentioned this pull request May 18, 2016

Update deployment user guide when new commands are merged kubernetes/website#498

Closed

2 tasks

rosskukulinski mentioned this pull request Sep 13, 2016

Consider replacing verify-deployment with kubectl rollout status rosskukulinski/k8s-scripts#9

Open

bgrant0607 mentioned this pull request Jan 18, 2019

apiextensions: validate status.observedGeneration for custom resources #64379

Closed

stcheng reviewed Dec 2, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `kubectl rollout status` #19946

Add `kubectl rollout status` #19946

janetkuo commented Jan 21, 2016 •

edited

Loading

janetkuo commented Jan 21, 2016

ghodss commented Jan 21, 2016

janetkuo commented Jan 21, 2016

bgrant0607 commented Jan 22, 2016

janetkuo commented Jan 22, 2016

janetkuo commented Jan 22, 2016

bgrant0607 commented Jan 30, 2016

0xmichalis May 9, 2016

janetkuo commented May 10, 2016

0xmichalis May 10, 2016

janetkuo May 10, 2016

0xmichalis commented May 10, 2016

janetkuo commented May 10, 2016

0xmichalis commented May 10, 2016

janetkuo commented May 10, 2016

k8s-bot commented May 10, 2016

k8s-github-robot commented May 12, 2016

k8s-bot commented May 12, 2016

k8s-github-robot commented May 12, 2016

stcheng Dec 2, 2020

Add kubectl rollout status #19946

Add kubectl rollout status #19946

Conversation

janetkuo commented Jan 21, 2016 • edited Loading

Pull Request Guidelines

janetkuo commented Jan 21, 2016

ghodss commented Jan 21, 2016

janetkuo commented Jan 21, 2016

bgrant0607 commented Jan 22, 2016

janetkuo commented Jan 22, 2016

janetkuo commented Jan 22, 2016

bgrant0607 commented Jan 30, 2016

0xmichalis May 9, 2016

Choose a reason for hiding this comment

janetkuo commented May 10, 2016

0xmichalis May 10, 2016

Choose a reason for hiding this comment

janetkuo May 10, 2016

Choose a reason for hiding this comment

0xmichalis commented May 10, 2016

janetkuo commented May 10, 2016

0xmichalis commented May 10, 2016

janetkuo commented May 10, 2016

k8s-bot commented May 10, 2016

k8s-github-robot commented May 12, 2016

k8s-bot commented May 12, 2016

k8s-github-robot commented May 12, 2016

stcheng Dec 2, 2020

Choose a reason for hiding this comment

Add `kubectl rollout status` #19946

Add `kubectl rollout status` #19946

janetkuo commented Jan 21, 2016 •

edited

Loading