Add kubectl rollout history #19893

janetkuo · 2016-01-20T23:52:24Z

Addresses #17168; depends on #19581 and #19882.
See proposal.

Sample output:

$ kubectl rollout history deployment
Deployment "nginx-deployment":
REVISION    CHANGE-CAUSE
1           kubectl create -f deployment.yaml

Deployment "redis-deployment":
REVISION    CHANGE-CAUSE
1           kubectl create -f deployment.yaml
2           kubectl apply -f deployment.yaml

$ kubectl rollout history deployment --revision=1
Deployment "nginx-deployment" revision 1
Labels:     deployment.kubernetes.io/podTemplateHash=811039852,name=nginx
Annotations:    <none>
Image(s):   nginx
No volumes.

Deployment "redis-deployment" revision 1
Labels:     deployment.kubernetes.io/podTemplateHash=1905753157,name=redis
Annotations:    <none>
Image(s):   redis
No volumes.

cc @bgrant0607 @nikhiljindal @ironcladlou @Kargakis @kubernetes/sig-config @kubernetes/kubectl @madhusudancs

k8s-github-robot · 2016-01-20T23:58:09Z

Labelling this PR as size/XL

k8s-bot · 2016-01-21T01:09:35Z

GCE e2e test build/test passed for commit 889c3d9220f7ee040506330e7bec80a486e19c8c.

k8s-bot · 2016-01-21T02:29:22Z

GCE e2e test build/test passed for commit 065ff4e242eebd4076876540f1ec88ed1b7aba84.

bgrant0607 · 2016-01-22T04:54:51Z

pkg/kubectl/cmd/rollout/rollout_history.go

+			}
+			sort.Ints(versions)
+
+			fmt.Fprintf(out, "VERSION\n")


The initial version doesn't need to be too fancy, but how about displaying change-source?

It might also make sense to add a column for the image, since that will often be what changed.

In the future, we might also want to think about how to summarize what changed, perhaps by doing a strategic diff and categorizing different parts of the pod template: image (I), env (E), volumes (V), resources (R), scheduling constraints (S), other (O).

bgrant0607 · 2016-01-22T04:56:35Z

cc @ghodss

bgrant0607 · 2016-01-25T23:20:00Z

Needs to be updated to Revision, but otherwise looks like a reasonable first cut.

k8s-github-robot · 2016-01-29T19:19:43Z

PR needs rebase

k8s-github-robot · 2016-01-30T00:43:54Z

Labelling this PR as size/XXL

k8s-bot · 2016-01-30T01:13:00Z

GCE e2e test build/test passed for commit 3929a787714a16a38ae4c4b0f9cb3f724da2ef42.

janetkuo · 2016-01-30T01:45:09Z

@bgrant0607 Code updated; PTAL (Note that the support for recording kubectl commands is in #20035 but not here)

Sample output:

$ kubectl rollout history deployment
Deployment "nginx-deployment":
REVISION    CHANGE-CAUSE
1           kubectl create -f deployment.yaml

Deployment "redis-deployment":
REVISION    CHANGE-CAUSE
1           kubectl create -f deployment.yaml
2           kubectl apply -f deployment.yaml

$ kubectl rollout history deployment --revision=1
Deployment "nginx-deployment" revision 1
Labels:     deployment.kubernetes.io/podTemplateHash=811039852,name=nginx
Annotations:    <none>
Image(s):   nginx
No volumes.

Deployment "redis-deployment" revision 1
Labels:     deployment.kubernetes.io/podTemplateHash=1905753157,name=redis
Annotations:    <none>
Image(s):   redis
No volumes.

k8s-bot · 2016-01-31T02:20:55Z

GCE e2e test build/test passed for commit 86e8d37551b2026af599d753485938c77cedc56b.

0xmichalis · 2016-01-31T12:53:38Z

pkg/kubectl/cmd/rollout/rollout_history.go

+		Latest().
+		Flatten().
+		Do()
+	err = r.Err()


This check is redundant, r.Infos() will run it for you

k8s-bot · 2016-02-01T18:51:47Z

GCE e2e build/test failed for commit d777c2256c98fb3f5b016fd6f2f96f8e2ea9015b.

janetkuo · 2016-02-01T19:09:47Z

@Kargakis all comments addressed; PTAL

k8s-bot · 2016-02-01T19:41:09Z

GCE e2e test build/test passed for commit 0f28ffcfba1aa72ef418fd4e4d85724139533630.

0xmichalis · 2016-02-01T20:48:43Z

pkg/kubectl/cmd/util/helpers.go

@@ -42,7 +42,8 @@ import (
 )

 const (
-	ApplyAnnotationsFlag = "save-config"
+	ApplyAnnotationsFlag  = "save-config"
+	ChangeCauseAnnotation = "kubernetes.io/change-cause"


I see this annotation twice; here and in pkg/kubectl/history.go

Removed it here

janetkuo · 2016-02-01T22:00:26Z

@Kargakis PTAL

k8s-bot · 2016-02-01T22:33:46Z

GCE e2e test build/test passed for commit feee1565598e31299312e9ecee6209bb8494ed5b.

0xmichalis · 2016-02-01T22:38:28Z

pkg/kubectl/history.go

+		errs := []error{}
+		for _, r := range revisions {
+			// Find the change-cause of revision r
+			r64, err := strconv.ParseInt(r, 10, 64)


ugh, this is tiring. How about:

var revisions []int for k := range historyInfo.RevisionToTemplate { revisions = append(revisions, int(k)) } sort.Ints(revisions) // ... for _, r := range revisions { changeCause := historyInfo.RevisionToTemplate[int64(r)].Annotations[ChangeCauseAnnotation] // ...

revision is int64 and sort doesn't supports int64.

Note that I cast between int and int64 which is better than casting between strings and int64

Also https://golang.org/pkg/sort/#Ints

What if revision is something like int64(3546343826724305832)? It's incorrect after int(revision).

Well, I guess string->int64 is safer. But will we ever get to such numbers? Anyway, I am fine with this too

0xmichalis · 2016-02-01T22:43:15Z

two last comments, lgtm after they are addressed and you squash

janetkuo · 2016-02-01T23:37:05Z

Squashed. PTAL on the comment that's not addressed.

k8s-bot · 2016-02-02T00:09:33Z

GCE e2e test build/test passed for commit 8fb86a3.

k8s-github-robot · 2016-02-02T08:41:07Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-02-02T09:12:58Z

GCE e2e test build/test passed for commit 8fb86a3.

k8s-github-robot · 2016-02-02T09:13:15Z

Automatic merge from submit-queue

Auto commit by PR queue bot

janetkuo added area/app-lifecycle area/kubectl labels Jan 20, 2016

googlebot added the cla: yes label Jan 20, 2016

k8s-github-robot assigned lavalamp Jan 20, 2016

k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2016

janetkuo mentioned this pull request Jan 21, 2016

Develop Deployment UX equivalent to kubectl rolling-update #17168

Closed

janetkuo force-pushed the kubectl-rollout-history branch from 889c3d9 to 065ff4e Compare January 21, 2016 00:59

bgrant0607 assigned bgrant0607 and unassigned lavalamp Jan 22, 2016

bgrant0607 reviewed Jan 22, 2016
View reviewed changes

janetkuo mentioned this pull request Jan 22, 2016

Record kubectl commands (useful when viewing rollout history); copy deployment's annotations to its RC #20035

Merged

janetkuo added this to the v1.2 milestone Jan 23, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2016

janetkuo force-pushed the kubectl-rollout-history branch from 065ff4e to 3929a78 Compare January 30, 2016 00:43

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2016

janetkuo force-pushed the kubectl-rollout-history branch from 3929a78 to ee29c56 Compare January 30, 2016 01:37

janetkuo changed the title ~~RFC: Add kubectl rollout history [LGTM]~~ Add kubectl rollout history [LGTM] Jan 31, 2016

0xmichalis reviewed Jan 31, 2016
View reviewed changes

janetkuo force-pushed the kubectl-rollout-history branch from d777c22 to 0f28ffc Compare February 1, 2016 19:08

0xmichalis reviewed Feb 1, 2016
View reviewed changes

Add kubectl rollout history

8fb86a3

janetkuo force-pushed the kubectl-rollout-history branch from feee156 to 8fb86a3 Compare February 1, 2016 23:35

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2016

janetkuo changed the title ~~Add kubectl rollout history [LGTM]~~ Add kubectl rollout history Feb 2, 2016

k8s-github-robot pushed a commit that referenced this pull request Feb 2, 2016

Merge pull request #19893 from janetkuo/kubectl-rollout-history

17a5058

Auto commit by PR queue bot

k8s-github-robot merged commit 17a5058 into kubernetes:master Feb 2, 2016

janetkuo added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add kubectl rollout history #19893

Add kubectl rollout history #19893

janetkuo commented Jan 20, 2016

k8s-github-robot commented Jan 20, 2016

k8s-bot commented Jan 21, 2016

k8s-bot commented Jan 21, 2016

bgrant0607 Jan 22, 2016

bgrant0607 commented Jan 22, 2016

bgrant0607 commented Jan 25, 2016

k8s-github-robot commented Jan 29, 2016

k8s-github-robot commented Jan 30, 2016

k8s-bot commented Jan 30, 2016

janetkuo commented Jan 30, 2016

k8s-bot commented Jan 31, 2016

0xmichalis Jan 31, 2016

janetkuo Feb 1, 2016

k8s-bot commented Feb 1, 2016

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 1, 2016

0xmichalis Feb 1, 2016

janetkuo Feb 1, 2016

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 1, 2016

0xmichalis Feb 1, 2016

janetkuo Feb 1, 2016

0xmichalis Feb 1, 2016

janetkuo Feb 1, 2016

0xmichalis Feb 2, 2016

0xmichalis commented Feb 1, 2016

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 2, 2016

k8s-github-robot commented Feb 2, 2016

k8s-bot commented Feb 2, 2016

k8s-github-robot commented Feb 2, 2016

Add kubectl rollout history #19893

Add kubectl rollout history #19893

Conversation

janetkuo commented Jan 20, 2016

k8s-github-robot commented Jan 20, 2016

k8s-bot commented Jan 21, 2016

k8s-bot commented Jan 21, 2016

Choose a reason for hiding this comment

bgrant0607 commented Jan 22, 2016

bgrant0607 commented Jan 25, 2016

k8s-github-robot commented Jan 29, 2016

k8s-github-robot commented Jan 30, 2016

k8s-bot commented Jan 30, 2016

janetkuo commented Jan 30, 2016

k8s-bot commented Jan 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-bot commented Feb 1, 2016

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmichalis commented Feb 1, 2016

janetkuo commented Feb 1, 2016

k8s-bot commented Feb 2, 2016

k8s-github-robot commented Feb 2, 2016

k8s-bot commented Feb 2, 2016

k8s-github-robot commented Feb 2, 2016