Pin golang build to 1.4.2 instead of floating on 1.4 and force pull the base golang image #19847
Conversation
ikehz
added
priority/critical-urgent
|
This should be backported to 1.1 and is cause for a new |
k8s-github-robot
added
the
size/XS
|
Labelling this PR as size/XS |
ikehz
changed the title
| @@ -490,16 +490,19 @@ function kube::build::build_image_cross() { | |||
| local -r build_context_dir="${LOCAL_OUTPUT_ROOT}/images/${KUBE_BUILD_IMAGE}/cross" | |||
| mkdir -p "${build_context_dir}" | |||
| cp build/build-image/cross/Dockerfile ${build_context_dir}/Dockerfile | |||
| kube::build::docker_build "${KUBE_BUILD_IMAGE_CROSS}" "${build_context_dir}" | |||
| kube::build::docker_build "${KUBE_BUILD_IMAGE_CROSS}" "${build_context_dir}" 'true' | |||
There was a problem hiding this comment.
and is there a reason to leave the one on L483 as false?
There was a problem hiding this comment.
why single quotes?
Double-quotes indicates substitution intended, single-quotes indicates literal.
and is there a reason to leave the one on L483 as false?
Yes, if we try to force-pull image that only exists locally (i.e. the image that the one on L483 is built on) Docker complains that it can't pull the image. I will add a note. Or maybe I should default to true?
|
GCE e2e test build/test passed for commit e95dd01. |
|
GCE e2e test build/test passed for commit 5a383ed6ac538bc2df0d5f121cba2851425211d4. |
|
GCE e2e test build/test passed for commit 09b2cc8a0f21bc1ce041d08cc73ee2cf9934657c. |
|
LGTM once you address @ixdy's comments |
|
Labelling this PR as size/S |
k8s-github-robot
added
size/S
|
GCE e2e build/test failed for commit 041f152. |
| kube::build::docker_build "${KUBE_BUILD_IMAGE}" "${build_context_dir}" | ||
| # We don't want to force-pull this image because it's based on a local image | ||
| # (see kube::build::build_image_cross), not upstream. | ||
| kube::build::docker_build "${KUBE_BUILD_IMAGE}" "${build_context_dir}" 'false' |
There was a problem hiding this comment.
Ah, yeah, that's obvious. Thanks.
zmerlynn
added
the
lgtm
|
@k8s-bot e2e test this |
|
GCE e2e build/test failed for commit 041f152. |
|
@k8s-bot e2e test this again please |
|
LGTM2 |
|
GCE e2e test build/test passed for commit 041f152. |
|
@k8s-oncall can we merge this manually to get the tests stable again? |
|
(@k8s-oncall we also need to backport this to |
|
Also release-1.0 (if we still care about that?) |
|
@ihmccreery: Er, when did cherry picks shift to @k8s-oncall's responsibility? |
Oh, no, I didn't mean it was their responsibility; just that we should get this merged asap so I can cherrypick it. |
Pin golang build to 1.4.2 instead of floating on 1.4 and force pull the base golang image
…847-upstream-release-1.1 Automated cherry pick of #19847
…847-upstream-release-1.0 Automated cherry pick of #19847
…ick-of-#19847-upstream-release-1.1 Automated cherry pick of kubernetes#19847
…ick-of-#19847-upstream-release-1.1 Automated cherry pick of kubernetes#19847
We've experienced some performance regressions since latest golang went from 1.4.2 to 1.4.3. We should pin at a known-good version, at least for now. (#17524)