Allow Meta lookup to work across ObjectType and ListMeta #1969
Conversation
Prepares for the meta object to front multiple underlying types when TypeMeta and ObjectMeta is split in internal and v1beta3, but combined in v1beta1 and v1beta2
|
Can you explain for dummies like me why this is better than just finding and returning a *TypeMeta? |
|
Different api objects have different metas, so you can't cast them in memory (v1beta1 vs 2). I think eventually we can split support into internal vs non internal and have internal return *ObjectMeta and *TypeMeta for the fast path. For now though I wanted to do the mechanical transformations.
|
|
Ahh, right. This is not just different internal type, but internal AND On Wed, Oct 22, 2014 at 9:43 PM, Clayton Coleman notifications@github.com
|
|
This is in my queue as soon as I fix e2e |
| return a, nil | ||
| } | ||
|
|
||
| // NewResourceVersioner returns a ResourceVersioner that can set or |
There was a problem hiding this comment.
What do you think about killing ResourceVersioner & SelfLinker and making everyone use Accessor?
There was a problem hiding this comment.
I like it - I'll queue up an issue for it. Once we need to access annotations generically that becomes important as well.
|
LGTM, comments more or less optional |
|
Added review comments about renaming and the nits. Will remove SelfLinker and ResourceVersioner indirection and duplication in latest and apis in a follow on issue. |
|
LGTM |
Allow Meta lookup to work across ObjectType and ListMeta
OCPBUGS-33711: Bump to Kubernetes v1.28.10
Extracted from #1600