Remove FailedResourceType and return custom error #19527
Conversation
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
GCE e2e test build/test passed for commit fc79be0c0dc09d1960fc8553be9fb51663d9acd9. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
| fit, err := predicate(pod, machineToPods[node.Name], node.Name) | ||
| if err != nil { | ||
| return api.NodeList{}, FailedPredicateMap{}, err | ||
| switch err.(type) { | ||
| case *predicates.InsufficientResourceError: |
There was a problem hiding this comment.
for this case can you do some kind of assertion that !fit ?
| return api.NodeList{}, FailedPredicateMap{}, err | ||
| switch e := err.(type) { | ||
| case *predicates.InsufficientResourceError: | ||
| if fit { |
There was a problem hiding this comment.
@davidopp
Addressed.
|
GCE e2e test build/test passed for commit 252a956. |
|
The failing unit test is known flaky: |
|
LGTM |
davidopp
added
lgtm
|
@k8s-bot unit test this please |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 252a956. |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 252a956. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 252a956. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
To continue our discussion and work in #19487 and #19296.
The previous commit in #19296 didn't check the custom error from predicate() which caused failure cases.
Please let me know what you think. Highly appreciate it! @saad-ali @gmarek @lavalamp