Make kube2sky and skydns docker images cross-platform #19376

luxas · 2016-01-07T20:46:43Z

ARM tracking issue: #17981
Continues on: #19216

Make it possible to create kube2sky and skydns docker images for ARM and other architectures too
Build in a container, so golang isn't a dependency
I've preserved the original default behaviour:

skydns: It just compiles with go on host
kube2sky: Build an image

@brendandburns @dchen1107 @ArtfulCoder @thockin @fgrzadkowski

k8s-bot · 2016-01-07T20:47:12Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-01-07T20:48:12Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot · 2016-01-07T20:50:17Z

Labelling this PR as size/L

luxas · 2016-01-11T19:42:17Z

Friendly ping @thockin @brendandburns. Trigger the tests at least :)

thockin · 2016-01-12T05:42:17Z

cluster/addons/dns/kube2sky/Makefile

-	docker build -t $(PREFIX)/kube2sky:$(TAG) .
+ifeq ($(ARCH),amd64)
+	# Backward compatability. TODO: deprecate this image tag
+	docker tag -f ${REGISTRY}/kube2sky-${ARCH}:${TAG} ${REGISTRY}/kube2sky:${TAG}


It seems that make supports ${} but $() is more common - minor point, but I even had to go look to make sure ${} was right.

Yes, ${} works, at least locally :)
One example of ${} usage is the hyperkube Makefile now.
It heavily uses ${} and I think we should choose one of them

I much prefer $() for make variables.

OK, I'll update this one if you prefer

thockin · 2016-01-12T05:45:21Z

I think this is OK, but it doesn't include the usage of the new -ARCH container. Is that coming later?

luxas · 2016-01-12T06:29:55Z

Yes, that for the next PR.
It's better to do that when you guys have pushed the images, when all the -ARCH containers is pullable
It it OK to merge then?

luxas · 2016-01-17T14:53:37Z

@thockin @brendandburns Replaced ${} with $().
Is it OK to merge?

luxas · 2016-01-19T21:12:23Z

@thockin @brendandburns PTAL

luxas · 2016-01-25T08:48:50Z

Ping @thockin

k8s-bot · 2016-01-28T18:47:26Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-01-28T19:43:15Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-02-03T05:11:13Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot · 2016-02-04T03:56:24Z

PR needs rebase

k8s-bot · 2016-02-04T19:35:04Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

luxas · 2016-02-07T19:59:39Z

@thockin I really understand if you have much to do, but could you a) LGTM or b) reassign this

Then, in another PR, we should cut new kube2sky and skydns releases, and update the .yaml files to the new -ARCH name.

k8s-bot · 2016-02-07T20:25:28Z

GCE e2e test build/test passed for commit 194fdc672e6680dfc3b3f123d17602fb33eff85d.

k8s-github-robot · 2016-02-07T20:30:25Z

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

luxas · 2016-02-21T12:10:25Z

@fgrzadkowski Can you kindly take a look at this, and maybe push the images?
It should be OK, as @thockin said above.
I really understand if you have much to do now when you're preparing for v1.2...

k8s-bot · 2016-02-23T23:38:07Z

GCE e2e build/test failed for commit 194fdc672e6680dfc3b3f123d17602fb33eff85d.

k8s-github-robot · 2016-03-04T20:50:40Z

@luxas PR needs rebase

k8s-github-robot · 2016-04-09T20:51:35Z

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

k8s-bot · 2016-04-09T21:20:27Z

GCE e2e build/test passed for commit b3015e1a4e4113d0b0d07031ab64abf825db4932.

k8s-github-robot · 2016-04-10T21:19:01Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-10T21:50:41Z

GCE e2e build/test passed for commit b3015e1a4e4113d0b0d07031ab64abf825db4932.

k8s-github-robot · 2016-04-10T22:23:33Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-10T22:55:26Z

GCE e2e build/test passed for commit b3015e1a4e4113d0b0d07031ab64abf825db4932.

bprashanth · 2016-04-10T23:17:35Z

cluster/addons/dns/kube2sky/Changelog

@@ -1,3 +1,9 @@
+## Version 1.15 (Apr 7 2016 Lucas Käldström <lucas.kaldstrom@hotmail.co.uk>)
+ - No code changes since 1.14


what version was 1.14 built with? probably want to include that this is using go 1.6

I don't know which version 1.14 was built with (as it was using go on host), but adding a note about go1.6

k8s-github-robot · 2016-04-11T02:29:15Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-11T03:03:13Z

GCE e2e build/test passed for commit b3015e1a4e4113d0b0d07031ab64abf825db4932.

…m64 and ppc64le

luxas · 2016-04-11T04:35:43Z

@david-mcmahon Updated. PTAL

k8s-bot · 2016-04-11T05:03:18Z

GCE e2e build/test passed for commit 1c8140c.

k8s-github-robot · 2016-04-11T07:43:48Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-11T08:13:45Z

GCE e2e build/test passed for commit 1c8140c.

k8s-github-robot · 2016-04-11T09:17:33Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-11T09:49:40Z

GCE e2e build/test passed for commit 1c8140c.

k8s-github-robot · 2016-04-11T12:15:00Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-11T12:44:24Z

GCE e2e build/test passed for commit 1c8140c.

k8s-github-robot · 2016-04-11T12:47:10Z

Automatic merge from submit-queue

googlebot added the cla: yes label Jan 7, 2016

luxas mentioned this pull request Jan 7, 2016

[Proposal] Make Kubernetes run on ARM devices #17981

Closed

17 tasks

k8s-github-robot assigned thockin Jan 7, 2016

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2016

thockin reviewed Jan 12, 2016
View reviewed changes

luxas force-pushed the dns_cross_platform branch from a6de1ed to bf49f96 Compare January 17, 2016 14:51

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2016

luxas force-pushed the dns_cross_platform branch from bf49f96 to 194fdc6 Compare February 7, 2016 19:56

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2016

k8s-github-robot added the needs-ok-to-merge label Feb 7, 2016

david-mcmahon added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge and removed needs-ok-to-merge labels Apr 7, 2016

bprashanth assigned ArtfulCoder and unassigned david-mcmahon Apr 10, 2016

bprashanth reviewed Apr 10, 2016
View reviewed changes

bprashanth assigned david-mcmahon and unassigned ArtfulCoder Apr 10, 2016

david-mcmahon removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2016

Make kube2sky and skydns docker images cross-platform: amd64, arm, ar…

1c8140c

…m64 and ppc64le

luxas force-pushed the dns_cross_platform branch from b3015e1 to 1c8140c Compare April 11, 2016 04:32

david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2016

k8s-github-robot merged commit 78dc9c7 into kubernetes:master Apr 11, 2016

		@@ -1,3 +1,9 @@
		## Version 1.15 (Apr 7 2016 Lucas Käldström <lucas.kaldstrom@hotmail.co.uk>)
		- No code changes since 1.14

Make kube2sky and skydns docker images cross-platform #19376

Make kube2sky and skydns docker images cross-platform #19376

Conversation

luxas commented Jan 7, 2016

k8s-bot commented Jan 7, 2016

k8s-bot commented Jan 7, 2016

k8s-github-robot commented Jan 7, 2016

luxas commented Jan 11, 2016

thockin Jan 12, 2016

Choose a reason for hiding this comment

luxas Jan 12, 2016

Choose a reason for hiding this comment

thockin Jan 16, 2016

Choose a reason for hiding this comment

luxas Jan 16, 2016

Choose a reason for hiding this comment

thockin commented Jan 12, 2016

luxas commented Jan 12, 2016

luxas commented Jan 17, 2016

luxas commented Jan 19, 2016

luxas commented Jan 25, 2016

k8s-bot commented Jan 28, 2016

k8s-bot commented Jan 28, 2016

k8s-bot commented Feb 3, 2016

k8s-github-robot commented Feb 4, 2016

k8s-bot commented Feb 4, 2016

luxas commented Feb 7, 2016

k8s-bot commented Feb 7, 2016

k8s-github-robot commented Feb 7, 2016

luxas commented Feb 21, 2016

k8s-bot commented Feb 23, 2016

k8s-github-robot commented Mar 4, 2016

k8s-github-robot commented Apr 9, 2016

k8s-bot commented Apr 9, 2016

k8s-github-robot commented Apr 10, 2016

k8s-bot commented Apr 10, 2016

k8s-github-robot commented Apr 10, 2016

k8s-bot commented Apr 10, 2016

bprashanth Apr 10, 2016

Choose a reason for hiding this comment

david-mcmahon Apr 11, 2016

Choose a reason for hiding this comment

luxas Apr 11, 2016

Choose a reason for hiding this comment

k8s-github-robot commented Apr 11, 2016

k8s-bot commented Apr 11, 2016

luxas commented Apr 11, 2016

k8s-bot commented Apr 11, 2016

k8s-github-robot commented Apr 11, 2016

k8s-bot commented Apr 11, 2016

k8s-github-robot commented Apr 11, 2016

k8s-bot commented Apr 11, 2016

k8s-github-robot commented Apr 11, 2016

k8s-bot commented Apr 11, 2016

k8s-github-robot commented Apr 11, 2016