-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for custom vnet and dns #19126
Conversation
Similar to 62eb82d, this works around package refactoring and godep incompatibility
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
…ents after the test finishes.
Signed-off-by: Vishnu kannan <vishnuk@google.com>
@errordeveloper who has the most fingerprints here. |
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
@thockin thank you! |
@smashraf thank you very much for this contribution. It looks good to me overall. However, could you please ensure that your changes have consistent style with the rest of JavaScript code? |
Actually, I am seeing a whole bunch of changes here that do not relate to the subject. I think this needs to be rebased properly. |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
This PR has had no meaningful activity for multiple months. If it is still valid please rebase, push a new commit and reopen the PR. Thanks! |
The vnet over which cluster is to be created and the dns name can be set as environment variable