Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix etcdWatcher test #19010

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Fix etcdWatcher test #19010

merged 1 commit into from
Dec 22, 2015

Conversation

wojtek-t
Copy link
Member

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

GCE e2e test build/test passed for commit 0dadd1531c87376b4780c55f471f603b86765974.

@wojtek-t wojtek-t assigned gmarek and unassigned fgrzadkowski Dec 22, 2015
gmarek
gmarek reviewed Dec 22, 2015
View reviewed changes
pkg/storage/etcd/etcd_watcher_test.go
t.Errorf("An injected error did not cause a graceful shutdown")
// There is a race in etcdWatcher so that after calling Stop() one of
// two can happen:
// - ResultChan() may be close (triggered by closing userStop channel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/close/closed/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gmarek
Copy link
Contributor

gmarek commented Dec 22, 2015

two nits, LGTM otherwise.

@wojtek-t
Copy link
Member Author

@gmarek - PTAL

@wojtek-t
Copy link
Member Author

git -c core.askpass=true fetch --tags --progress https://github.com/kubernetes/kubernetes +refs/pull/:refs/remotes/origin/pr/
ERROR: Error fetching remote repo 'origin'

@k8s-bot unit test this please

@gmarek
Copy link
Contributor

gmarek commented Dec 22, 2015

We get this error quite often now:/
LGTM

@gmarek gmarek added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 22, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

GCE e2e test build/test passed for commit 8cd50dd.

mikedanese added a commit that referenced this pull request Dec 22, 2015
@mikedanese
Merge pull request #19010 from wojtek-t/debug_watcher_test
bee5822 
Fix etcdWatcher test
@mikedanese mikedanese merged commit bee5822 into kubernetes:master Dec 22, 2015
@wojtek-t wojtek-t deleted the debug_watcher_test branch December 28, 2015 10:41
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Mar 30, 2018
@k8s-publishing-bot
Merge pull request kubernetes#19010 from rootfs/pr-61284-3.9
cbc5b49 
UPSTREAM : 61284: Fix creation of subpath with SUID/SGID directories.

Origin-commit: 7df18152ebc429d904fba5260cb8385839eb3b55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wojtek-t @k8s-github-robot @k8s-bot @gmarek @k8s-teamcity-mesosphere @mikedanese @googlebot @fgrzadkowski